[improve][ci] revisit tune-runner-vm action, drop tuning for docker #22448
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- drop tuning for docker since it's no longer needed
- image squashing is deprecated and it's no longer used in the build to build
the docker image
- sometimes builds have been failing due to the docker service not restarting
lhotari
requested review from
merlimat,
Technoboy-,
nodece,
tisonkun and
dao-jun
|
example failure: https://github.com/apache/pulsar/actions/runs/8570670761/job/23489919722?pr=22446#step:3:114 |
lhotari
changed the title
tisonkun
approved these changes
Apr 5, 2024
nodece
approved these changes
Apr 5, 2024
|
It might be the case that the experimental mode is needed after all. Both docker image builds failed. I'm retrying the other docker image build to see if it's consistent. |
|
seems to fail consistently: |
This reverts commit f887ff7.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation & Modifications
Documentation
docdoc-requireddoc-not-neededdoc-complete