Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[fix][broker] Fix message drop record in producer stat #22458

Merged
merged 2 commits into from
Apr 10, 2024
Merged

[fix][broker] Fix message drop record in producer stat #22458

merged 2 commits into from
Apr 10, 2024

Conversation

zhangqian321
Copy link
Contributor

Motivation

msgDrop record message drop rate when non-persist message reached max concurrent-message limit in producer. 'valueRate' in msgDrop stands for message drop rate, and 'rate' stands for batch drop rate, and shoud get valueRate in publisherStats.

image

Modifications

get valueRate instead

Documentation

  • doc
  • doc-required
  • doc-not-needed
  • doc-complete

@github-actions github-actions bot added the doc-not-needed Your PR changes do not impact docs label Apr 8, 2024
@zhangqian321 zhangqian321 changed the title Fix message drop record in producer stat [fix][broker] Fix message drop record in producer stat Apr 8, 2024
lhotari
lhotari approved these changes Apr 9, 2024
View reviewed changes
Copy link
Member

@lhotari lhotari left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lhotari lhotari requested review from asafm and Technoboy- April 9, 2024 11:27
@lhotari lhotari requested a review from codelipenghui April 10, 2024 03:27
@Technoboy- Technoboy- added this to the 3.3.0 milestone Apr 10, 2024
@Technoboy- Technoboy- merged commit cea1a9b into apache:master Apr 10, 2024
52 of 54 checks passed
lhotari pushed a commit that referenced this pull request Apr 22, 2024
@zhangqian321 @lhotari
[fix][broker] Fix message drop record in producer stat (#22458)
b41e752 
Co-authored-by: ceceezhang <ceceezhang@tencent.com>
(cherry picked from commit cea1a9b)
lhotari pushed a commit that referenced this pull request Apr 22, 2024
@zhangqian321 @lhotari
[fix][broker] Fix message drop record in producer stat (#22458)
72d290a 
Co-authored-by: ceceezhang <ceceezhang@tencent.com>
(cherry picked from commit cea1a9b)
mukesh-ctds pushed a commit to datastax/pulsar that referenced this pull request Apr 23, 2024
@zhangqian321 @mukesh-ctds
[fix][broker] Fix message drop record in producer stat (apache#22458)
3f2c56a 
Co-authored-by: ceceezhang <ceceezhang@tencent.com>
(cherry picked from commit cea1a9b)
(cherry picked from commit b41e752)
srinath-ctds pushed a commit to datastax/pulsar that referenced this pull request Apr 23, 2024
@zhangqian321 @srinath-ctds
[fix][broker] Fix message drop record in producer stat (apache#22458)
ef4deb1 
Co-authored-by: ceceezhang <ceceezhang@tencent.com>
(cherry picked from commit cea1a9b)
(cherry picked from commit b41e752)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dao-jun dao-jun dao-jun approved these changes

@Technoboy- Technoboy- Technoboy- approved these changes

@lhotari lhotari lhotari approved these changes

@asafm asafm Awaiting requested review from asafm

@codelipenghui codelipenghui Awaiting requested review from codelipenghui

Assignees

@zhangqian321 zhangqian321

Labels
cherry-picked/branch-3.0 cherry-picked/branch-3.2 doc-not-needed Your PR changes do not impact docs ready-to-test release/3.0.5 release/3.2.3
Projects
None yet
Milestone
3.3.0
Development

Successfully merging this pull request may close these issues.
4 participants
@zhangqian321 @lhotari @Technoboy- @dao-jun