Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[improve][test] Replace usage of curl in Java test and fix stream leaks #22463

Merged
merged 1 commit into from
Apr 9, 2024

Conversation

lhotari
Copy link
Member

@lhotari lhotari commented Apr 9, 2024

Motivation

  • it's not a good practice to use curl in Java tests
  • the previous tests leaked some InputStream instances

Modification

  • replace curl usage with Java's built-in HttpURLConnection http client
  • use try-finally blocks for closing InputStreams

Documentation

  • doc
  • doc-required
  • doc-not-needed
  • doc-complete

- it's not a good practice to use curl in Java tests
- the previous tests leaked some InputStream instances
@lhotari lhotari added this to the 3.3.0 milestone Apr 9, 2024
@lhotari lhotari requested review from hangc0276 and Technoboy- April 9, 2024 10:04
@lhotari lhotari self-assigned this Apr 9, 2024
@lhotari lhotari requested a review from asafm April 9, 2024 10:05
@github-actions github-actions bot added the doc-not-needed Your PR changes do not impact docs label Apr 9, 2024
@lhotari lhotari requested review from eolivelli and hezhangjian April 9, 2024 11:04
@lhotari lhotari merged commit f3d14a6 into apache:master Apr 9, 2024
50 of 51 checks passed
lhotari added a commit to lhotari/pulsar that referenced this pull request Apr 15, 2024
lhotari added a commit to lhotari/pulsar that referenced this pull request Apr 15, 2024
lhotari added a commit that referenced this pull request Apr 15, 2024
lhotari added a commit to lhotari/pulsar that referenced this pull request Apr 15, 2024
mukesh-ctds pushed a commit to datastax/pulsar that referenced this pull request Apr 16, 2024
…ks (apache#22463)

(cherry picked from commit f3d14a6)
(cherry picked from commit 976399c)
mukesh-ctds pushed a commit to datastax/pulsar that referenced this pull request Apr 17, 2024
…ks (apache#22463)

(cherry picked from commit f3d14a6)
(cherry picked from commit 976399c)
mukesh-ctds pushed a commit to datastax/pulsar that referenced this pull request Apr 17, 2024
…ks (apache#22463)

(cherry picked from commit f3d14a6)
(cherry picked from commit 976399c)
mukesh-ctds pushed a commit to datastax/pulsar that referenced this pull request Apr 19, 2024
…ks (apache#22463)

(cherry picked from commit f3d14a6)
(cherry picked from commit 976399c)
srinath-ctds pushed a commit to datastax/pulsar that referenced this pull request Apr 23, 2024
…ks (apache#22463)

(cherry picked from commit f3d14a6)
(cherry picked from commit 976399c)
hanmz pushed a commit to hanmz/pulsar that referenced this pull request Feb 12, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants