[feat][admin] Enable Gzip Compression by Default in Admin Client #22464
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- By default, include "Accept-Encoding: gzip" header in HTTP requests - Support for controlling whether the header is added or not
lhotari
requested review from
merlimat,
hangc0276,
Technoboy-,
eolivelli,
codelipenghui,
nodece,
nicoloboschi and
mattisonchao
hezhangjian
approved these changes
Apr 9, 2024
Merged
4 tasks
nodece
reviewed
Apr 9, 2024
...ient-admin/src/main/java/org/apache/pulsar/client/admin/internal/PulsarAdminBuilderImpl.java
Show resolved
Hide resolved
nodece
reviewed
Apr 9, 2024
...-client-admin/src/test/java/org/apache/pulsar/client/admin/internal/PulsarAdminGzipTest.java
Show resolved
Hide resolved
nodece
approved these changes
Apr 9, 2024
hangc0276
approved these changes
Apr 11, 2024
15 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Gzip compression can reduce the amount of bytes transferred in the Pulsar Admin API.
The broker-side support for Gzip compression was added as part of #21667.
This PR adds support for Gzip compression to the Pulsar Admin Java client.
Modifications
Documentation
docdoc-requireddoc-not-neededdoc-complete