-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[fix][broker] Check the broker is available for the SLA monitor bundle when the ExtensibleLoadManager is enabled #22485
Merged
BewareMyPower
merged 5 commits into
apache:master
from
Demogorgon314:Demogorgon314/Check-the-broker-is-available-for-sla-monitor-bundle
Apr 18, 2024
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
heesung-sn
approved these changes
Apr 11, 2024
...src/main/java/org/apache/pulsar/broker/loadbalance/extensions/ExtensibleLoadManagerImpl.java
Outdated
Show resolved
Hide resolved
dragosvictor
approved these changes
Apr 11, 2024
BewareMyPower
requested changes
Apr 12, 2024
...src/main/java/org/apache/pulsar/broker/loadbalance/extensions/ExtensibleLoadManagerImpl.java
Outdated
Show resolved
Hide resolved
...src/main/java/org/apache/pulsar/broker/loadbalance/extensions/ExtensibleLoadManagerImpl.java
Show resolved
Hide resolved
gaoran10
approved these changes
Apr 12, 2024
BewareMyPower
approved these changes
Apr 18, 2024
heesung-sn
pushed a commit
to heesung-sn/pulsar
that referenced
this pull request
Jun 26, 2024
…e when the ExtensibleLoadManager is enabled (apache#22485) (cherry picked from commit d0b9d47)
heesung-sn
pushed a commit
to heesung-sn/pulsar
that referenced
this pull request
Jun 26, 2024
…e when the ExtensibleLoadManager is enabled (apache#22485) (cherry picked from commit d0b9d47)
heesung-sn
pushed a commit
to heesung-sn/pulsar
that referenced
this pull request
Jun 26, 2024
…e when the ExtensibleLoadManager is enabled (apache#22485) (cherry picked from commit d0b9d47) (cherry picked from commit c1a8596)
heesung-sn
pushed a commit
to heesung-sn/pulsar
that referenced
this pull request
Jun 26, 2024
…e when the ExtensibleLoadManager is enabled (apache#22485) (cherry picked from commit d0b9d47)
heesung-sn
pushed a commit
to heesung-sn/pulsar
that referenced
this pull request
Jun 26, 2024
…e when the ExtensibleLoadManager is enabled (apache#22485) (cherry picked from commit d0b9d47)
heesung-sn
pushed a commit
to heesung-sn/pulsar
that referenced
this pull request
Jun 26, 2024
…e when the ExtensibleLoadManager is enabled (apache#22485) (cherry picked from commit d0b9d47) (cherry picked from commit c1a8596)
heesung-sn
pushed a commit
to heesung-sn/pulsar
that referenced
this pull request
Jun 26, 2024
…e when the ExtensibleLoadManager is enabled (apache#22485) (cherry picked from commit d0b9d47) (cherry picked from commit c1a8596)
heesung-sn
pushed a commit
to heesung-sn/pulsar
that referenced
this pull request
Jun 26, 2024
…e when the ExtensibleLoadManager is enabled (apache#22485) (cherry picked from commit d0b9d47)
heesung-sn
pushed a commit
to heesung-sn/pulsar
that referenced
this pull request
Jun 27, 2024
…e when the ExtensibleLoadManager is enabled (apache#22485) (cherry picked from commit d0b9d47) (cherry picked from commit c1a8596)
nikhil-ctds
pushed a commit
to datastax/pulsar
that referenced
this pull request
Jun 27, 2024
…e when the ExtensibleLoadManager is enabled (apache#22485) (cherry picked from commit d0b9d47) (cherry picked from commit c1a8596) (cherry picked from commit f623be8)
srinath-ctds
pushed a commit
to datastax/pulsar
that referenced
this pull request
Jul 1, 2024
…e when the ExtensibleLoadManager is enabled (apache#22485) (cherry picked from commit d0b9d47) (cherry picked from commit c1a8596) (cherry picked from commit f623be8)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
cherry-picked/branch-3.0
cherry-picked/branch-3.2
doc-not-needed
Your PR changes do not impact docs
ready-to-test
release/3.0.6
release/3.2.4
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Check the broker is available for the SLA monitor bundle when the
ExtensibleLoadManager
is enabled to ensure the behavior same.Modifications
candidateBroker.substring(candidateBroker.lastIndexOf('/') + 1);
, because the [fix][broker] Fix leader broker cannot be determined when the advertised address and advertised listeners are configured #21894 already changed format.ExtensibleLoadManager
is enabledVerifying this change
Documentation
doc
doc-required
doc-not-needed
doc-complete