[fix][test] Flaky-test: testMessageExpiryWithTimestampNonRecoverableException and testIncorrectClientClock #22489
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…WithTimestampNonRecoverableException
lhotari
reviewed
Apr 12, 2024
pulsar-broker/src/test/java/org/apache/pulsar/broker/service/PersistentMessageFinderTest.java
Outdated
Show resolved
Hide resolved
shibd
commented
Apr 12, 2024
pulsar-broker/src/test/java/org/apache/pulsar/broker/service/PersistentMessageFinderTest.java
Show resolved
Hide resolved
poorbarcode
approved these changes
Apr 14, 2024
codelipenghui
approved these changes
Apr 15, 2024
|
/pulsarbot run-failure-checks |
shibd
changed the title
mukesh-ctds
pushed a commit
to datastax/pulsar
that referenced
this pull request
Apr 16, 2024
…xception and testIncorrectClientClock (apache#22489) (cherry picked from commit d9a43dd) (cherry picked from commit c590198)
mukesh-ctds
pushed a commit
to datastax/pulsar
that referenced
this pull request
Apr 17, 2024
…xception and testIncorrectClientClock (apache#22489) (cherry picked from commit d9a43dd) (cherry picked from commit c590198)
mukesh-ctds
pushed a commit
to datastax/pulsar
that referenced
this pull request
Apr 17, 2024
…xception and testIncorrectClientClock (apache#22489) (cherry picked from commit d9a43dd) (cherry picked from commit c590198)
mukesh-ctds
pushed a commit
to datastax/pulsar
that referenced
this pull request
Apr 19, 2024
…xception and testIncorrectClientClock (apache#22489) (cherry picked from commit d9a43dd) (cherry picked from commit c590198)
srinath-ctds
pushed a commit
to datastax/pulsar
that referenced
this pull request
Apr 23, 2024
…xception and testIncorrectClientClock (apache#22489) (cherry picked from commit d9a43dd) (cherry picked from commit c590198)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
#22351
#22432
After #22034, the calculation method for the ledger number should be:
totalEntries / entriesPerLedger + 1, However, since the creation of the ledger is asynchronous, sometimes the last ledger is not created before the function returns.pulsar/managed-ledger/src/main/java/org/apache/bookkeeper/mledger/impl/ManagedLedgerImpl.java
Lines 1775 to 1778 in 57a616e
Modifications
retryStrategically((test) -> ledger.getState() == ManagedLedgerImpl.State.LedgerOpened,10, 200)to make sure last ledger creates success.makePosition.Verifying this change
Documentation
docdoc-requireddoc-not-neededdoc-completeMatching PR in forked repository