-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[fix][broker] Fix Replicated Topic unload bug when ExtensibleLoadManager is enabled #22496
Conversation
@heesung-sn Please add the following content to your PR description and select a checkbox:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we also check the other place such as producer.close()
, looks like it may also get stuck forever.
I understand the producer.flush might get stuck if no leader broker is found in the cluster, but actually, I wonder how producer.close() can get stuck. |
Oh, I see it has |
public static Object[][] loadManagerClassName() { | ||
return new Object[][]{ | ||
{ModularLoadManagerImpl.class.getName()}, | ||
{ExtensibleLoadManagerImpl.class.getName()} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@heesung-sn I think that this is triggering a problem in tests.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sure. We can comment out this line if this is problematic.
…ger is enabled (apache#22496) (cherry picked from commit 203f305)
…ger is enabled (apache#22496) (cherry picked from commit 203f305)
…ger is enabled (apache#22496) (cherry picked from commit 203f305) (cherry picked from commit f467f37)
…ger is enabled (apache#22496) (cherry picked from commit 203f305)
…ger is enabled (apache#22496) (cherry picked from commit 203f305) (cherry picked from commit f467f37)
…ger is enabled (apache#22496) (cherry picked from commit 203f305) (cherry picked from commit f467f37)
…ger is enabled (apache#22496) (cherry picked from commit 203f305) (cherry picked from commit f467f37) (cherry picked from commit 2557db6)
…ger is enabled (apache#22496) (cherry picked from commit 203f305) (cherry picked from commit f467f37) (cherry picked from commit 2557db6)
Motivation
Noticed that Replicated Topic is not unloaded upon setNamespaceReplicationClusters when ExtensibleLoadManager is enabled.
Modifications
Verifying this change
Does this pull request potentially affect one of the following parts:
If the box was checked, please highlight the changes
Documentation
doc
doc-required
doc-not-needed
doc-complete
Matching PR in forked repository
PR in forked repository: