Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[improve][broker] Apply loadBalancerDebugModeEnabled in LeastResourceUsageWithWeight #22549

Conversation

BewareMyPower
Copy link
Contributor

Motivation

Info logs are not printed in LeastResourceUsageWithWeight even if loadBalancerDebugModeEnabled is true.

Modifications

Fix the TODO in LeastResourceUsageWithWeight.

Documentation

  • doc
  • doc-required
  • doc-not-needed
  • doc-complete

Matching PR in forked repository

PR in forked repository:

@BewareMyPower BewareMyPower self-assigned this Apr 22, 2024
@BewareMyPower BewareMyPower added this to the 3.3.0 milestone Apr 22, 2024
@github-actions github-actions bot added the doc-not-needed Your PR changes do not impact docs label Apr 22, 2024
@BewareMyPower BewareMyPower added type/enhancement The enhancements for the existing features or docs. e.g. reduce memory usage of the delayed messages area/broker and removed doc-not-needed Your PR changes do not impact docs labels Apr 22, 2024
@github-actions github-actions bot added the doc-not-needed Your PR changes do not impact docs label Apr 22, 2024
Copy link
Member

@lhotari lhotari left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@BewareMyPower BewareMyPower merged commit 882ce41 into apache:master Apr 23, 2024
55 of 59 checks passed
@BewareMyPower BewareMyPower deleted the bewaremypower/lb-debug-logs-strategy branch April 23, 2024 05:42
Technoboy- pushed a commit to Technoboy-/pulsar that referenced this pull request Apr 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/broker doc-not-needed Your PR changes do not impact docs ready-to-test type/enhancement The enhancements for the existing features or docs. e.g. reduce memory usage of the delayed messages
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants