-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[improve][meta] Log a warning when ZK batch fails with connectionloss #22566
[improve][meta] Log a warning when ZK batch fails with connectionloss #22566
Conversation
I might have encountered this issue recently when working on the /metrics endpoint issue. |
The test pulsar/pulsar-metadata/src/test/java/org/apache/pulsar/metadata/MetadataStoreBatchingTest.java Lines 151 to 182 in 61296d9
it will log "2024-04-23T17:03:51,416 - WARN - [main-EventThread:ZKMetadataStore@204] - Connection loss while executing batch operation of 40 GET entries of total data size of 910. Retrying individual operations one-by-one." with the changes in this PR. |
It seems that batching reads could cause more harm than benefit when the returned data exceeds jute.maxbuffer size. |
pulsar-metadata/src/main/java/org/apache/pulsar/metadata/impl/ZKMetadataStore.java
Show resolved
Hide resolved
…apache#22566) (cherry picked from commit 69839c7) (cherry picked from commit 701d4cf)
…apache#22566) (cherry picked from commit 69839c7) (cherry picked from commit 701d4cf)
Motivation
A batch operation might cause a connection to break which is a severe issue. It's better to log a warning whenever this happens instead of silently ignoring it.
Modifications
Documentation
doc
doc-required
doc-not-needed
doc-complete