[fix][broker] Fix BufferOverflowException and EOFException bugs in /metrics gzip compression #22576
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lhotari
added
type/bug
dao-jun
approved these changes
Apr 24, 2024
heesung-sn
approved these changes
Apr 24, 2024
lhotari
changed the title
Technoboy-
approved these changes
Apr 25, 2024
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #22576 +/- ##
============================================
+ Coverage 73.57% 73.95% +0.37%
+ Complexity 32624 32595 -29
============================================
Files 1877 1885 +8
Lines 139502 140520 +1018
Branches 15299 15452 +153
============================================
+ Hits 102638 103919 +1281
+ Misses 28908 28565 -343
- Partials 7956 8036 +80
Flags with carried forward coverage won't be shown. Click here to find out more.
|
nikhil-ctds
pushed a commit
to datastax/pulsar
that referenced
this pull request
May 13, 2024
…etrics gzip compression (apache#22576) (cherry picked from commit 997c8b9) (cherry picked from commit fe05e08)
srinath-ctds
pushed a commit
to datastax/pulsar
that referenced
this pull request
May 16, 2024
…etrics gzip compression (apache#22576) (cherry picked from commit 997c8b9) (cherry picked from commit fe05e08)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #22575
Motivation
See #22575 . This is a bug introduced by #22521. While fixing the bug, another related bug was revealed where it resulted in a EOFException when reading the gzipped content.
While working on this PR, another unrelated issue in the metrics output buffer pre-allocation was detected. It is also fixed in this PR. The impact of this is about 2x direct memory allocation since the pre-allocated buffers weren't used at all.
Modifications
capacitymethod to pre-allocate the buffer..setIndex(0, chunkSize)should have been called for the chunk before adding it. This is how thecapacitymethod increases the capacity.Documentation
docdoc-requireddoc-not-neededdoc-complete