Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[fix][test] Clear fields in test cleanup to reduce memory consumption #22583

Merged
merged 4 commits into from
Apr 25, 2024
Merged

[fix][test] Clear fields in test cleanup to reduce memory consumption #22583

merged 4 commits into from
Apr 25, 2024

Conversation

lhotari
Copy link
Member

@lhotari lhotari commented Apr 25, 2024 •
edited
Loading

Motivation

  • TestNG keeps a reference to the test instance and this will cause a OOME in some cases
image image

Modifications

  • Clear instances in the test classes that showed up as dominators in a heap dump

Documentation

  • doc
  • doc-required
  • doc-not-needed
  • doc-complete

@lhotari lhotari added this to the 3.3.0 milestone Apr 25, 2024
@lhotari lhotari self-assigned this Apr 25, 2024
@github-actions github-actions bot added the doc-not-needed Your PR changes do not impact docs label Apr 25, 2024
@lhotari lhotari marked this pull request as draft April 25, 2024 09:26
@lhotari lhotari force-pushed the lh-clear-fields-in-test-cleanup branch from e6ef331 to bd905a3 Compare April 25, 2024 09:56
@lhotari lhotari marked this pull request as ready for review April 25, 2024 09:56
@lhotari
[fix][test] Clear fields in test cleanup to reduce memory consumption
1679524 
- TestNG keeps a reference to the test instance and this will cause
  a OOME in some cases
@lhotari lhotari force-pushed the lh-clear-fields-in-test-cleanup branch from bd905a3 to 1679524 Compare April 25, 2024 10:06
@lhotari lhotari merged commit 3de14c5 into apache:master Apr 25, 2024
48 of 49 checks passed
lhotari added a commit that referenced this pull request Apr 26, 2024
@lhotari
[fix][test] Clear fields in test cleanup to reduce memory consumption (…
72833fe 
…#22583)

(cherry picked from commit 3de14c5)
lhotari added a commit that referenced this pull request Apr 26, 2024
@lhotari
[fix][test] Clear fields in test cleanup to reduce memory consumption (…
1be23d0 
…#22583)

(cherry picked from commit 3de14c5)
This was referenced May 6, 2024
Merged
Merged
nikhil-ctds pushed a commit to datastax/pulsar that referenced this pull request May 13, 2024
@lhotari @nikhil-ctds
[fix][test] Clear fields in test cleanup to reduce memory consumption (…
f7f7c04 
…apache#22583)

(cherry picked from commit 3de14c5)
(cherry picked from commit 72833fe)
srinath-ctds pushed a commit to datastax/pulsar that referenced this pull request May 16, 2024
@lhotari @srinath-ctds
[fix][test] Clear fields in test cleanup to reduce memory consumption (…
07b40ee 
…apache#22583)

(cherry picked from commit 3de14c5)
(cherry picked from commit 72833fe)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Technoboy- Technoboy- Technoboy- approved these changes

@poorbarcode poorbarcode Awaiting requested review from poorbarcode

Assignees

@lhotari lhotari

Labels
area/test cherry-picked/branch-3.0 cherry-picked/branch-3.2 doc-not-needed Your PR changes do not impact docs ready-to-test release/3.0.5 release/3.2.3
Projects
None yet
Milestone
3.3.0
Development

Successfully merging this pull request may close these issues.
2 participants
@lhotari @Technoboy-