[fix][ml]Fix subscription props could be lost in case of missing ledger during recovery #22637
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@nicoloboschi Please add the following content to your PR description and select a checkbox: |
github-actions
bot
added
doc-not-needed
nicoloboschi
requested review from
lhotari,
codelipenghui and
eolivelli
and removed request for
lhotari and
codelipenghui
BewareMyPower
approved these changes
May 20, 2024
dao-jun
approved these changes
May 20, 2024
Technoboy-
changed the title
Technoboy-
pushed a commit
that referenced
this pull request
May 21, 2024
… during recovery (#22637)
Technoboy-
pushed a commit
that referenced
this pull request
May 21, 2024
… during recovery (#22637)
nikhil-ctds
pushed a commit
to datastax/pulsar
that referenced
this pull request
May 31, 2024
… during recovery (apache#22637) (cherry picked from commit 5bbb62d)
nikhil-ctds
pushed a commit
to datastax/pulsar
that referenced
this pull request
Jun 4, 2024
… during recovery (apache#22637) (cherry picked from commit 5bbb62d)
nikhil-ctds
pushed a commit
to datastax/pulsar
that referenced
this pull request
Jun 4, 2024
… during recovery (apache#22637) (cherry picked from commit 5bbb62d)
srinath-ctds
pushed a commit
to datastax/pulsar
that referenced
this pull request
Jun 7, 2024
… during recovery (apache#22637) (cherry picked from commit 5bbb62d)
lhotari
added
release/3.0.6
release/3.2.4
and removed
release/3.0.5
release/3.2.3
labels
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
During the recovery of the cursor, if the stored position points to a non existent ledger, the cursor is rewinded to the oldest position. In this case the subscription properties won't be stored in the managedcursor info on the metadata store
Modifications
Verifying this change
Make sure that the change passes the CI checks.
doc-not-needed