-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[improve] [broker] Trigger offload on topic load #22652
[improve] [broker] Trigger offload on topic load #22652
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
managed-ledger/src/main/java/org/apache/bookkeeper/mledger/impl/ManagedLedgerFactoryImpl.java
Outdated
Show resolved
Hide resolved
close reopen to trigger ci workflow |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #22652 +/- ##
============================================
- Coverage 73.57% 70.57% -3.00%
+ Complexity 32624 32224 -400
============================================
Files 1877 1890 +13
Lines 139502 150413 +10911
Branches 15299 17744 +2445
============================================
+ Hits 102638 106157 +3519
- Misses 28908 35867 +6959
- Partials 7956 8389 +433
Flags with carried forward coverage won't be shown. Click here to find out more.
|
(cherry picked from commit 400a286)
Fixes #xyz
Main Issue: #xyz
PIP: PIP-348
Motivation
Implement of PIP-348
Modifications
Verifying this change
(Please pick either of the following options)
This change is a trivial rework / code cleanup without any test coverage.
(or)
This change is already covered by existing tests, such as (please describe tests).
(or)
This change added tests and can be verified as follows:
(example:)
Does this pull request potentially affect one of the following parts:
If the box was checked, please highlight the changes
Documentation
doc
doc-required
doc-not-needed
doc-complete
Matching PR in forked repository
PR in forked repository: