-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[improve] [test] Add a test to guarantee the TNX topics will not be replicated #22721
Merged
dao-jun
merged 4 commits into
apache:master
from
poorbarcode:fix/clear_txn_info_when_replicating
May 16, 2024
Merged
[improve] [test] Add a test to guarantee the TNX topics will not be replicated #22721
dao-jun
merged 4 commits into
apache:master
from
poorbarcode:fix/clear_txn_info_when_replicating
May 16, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
poorbarcode
requested review from
lhotari,
Technoboy-,
codelipenghui,
gaoran10,
congbobo184 and
liangyepianzhou
May 15, 2024 16:52
congbobo184
approved these changes
May 16, 2024
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #22721 +/- ##
============================================
- Coverage 73.57% 73.18% -0.39%
+ Complexity 32624 2506 -30118
============================================
Files 1877 1889 +12
Lines 139502 141385 +1883
Branches 15299 15514 +215
============================================
+ Hits 102638 103478 +840
- Misses 28908 29910 +1002
- Partials 7956 7997 +41
Flags with carried forward coverage won't be shown. Click here to find out more. |
dao-jun
approved these changes
May 16, 2024
nikhil-ctds
pushed a commit
to datastax/pulsar
that referenced
this pull request
May 31, 2024
…eplicated (apache#22721) (cherry picked from commit 4e132d3) (cherry picked from commit b11ab69)
nikhil-ctds
pushed a commit
to datastax/pulsar
that referenced
this pull request
Jun 4, 2024
…eplicated (apache#22721) (cherry picked from commit 4e132d3) (cherry picked from commit b11ab69)
nikhil-ctds
pushed a commit
to datastax/pulsar
that referenced
this pull request
Jun 4, 2024
…eplicated (apache#22721) (cherry picked from commit 4e132d3) (cherry picked from commit b11ab69)
Technoboy-
pushed a commit
that referenced
this pull request
Jun 6, 2024
srinath-ctds
pushed a commit
to datastax/pulsar
that referenced
this pull request
Jun 7, 2024
…eplicated (apache#22721) (cherry picked from commit 4e132d3) (cherry picked from commit b11ab69)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
area/test
cherry-picked/branch-3.0
cherry-picked/branch-3.2
cherry-picked/branch-3.3
doc-not-needed
Your PR changes do not impact docs
ready-to-test
release/3.0.6
release/3.2.4
release/3.3.1
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation & Modifications
Documentation
doc
doc-required
doc-not-needed
doc-complete
Matching PR in forked repository
PR in forked repository: x