[improve] [broker] Do not call cursor.isCursorDataFullyPersistable if disabled dispatcherPauseOnAckStatePersistentEnabled #22729
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… disabled dispatcherPauseOnAckStatePersistentEnabled
codelipenghui
approved these changes
May 17, 2024
|
/pulsarbot rerun-failure-checks |
coderzc
approved these changes
May 17, 2024
Technoboy-
approved these changes
May 17, 2024
Technoboy-
pushed a commit
that referenced
this pull request
Jun 6, 2024
… disabled dispatcherPauseOnAckStatePersistentEnabled (#22729)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
The method
cursor.isCursorDataFullyPersistablewas added with PIP-299-part-1: Stop dispatch messages if the individual acks will be lost in the persistent storage, it used to check if the dispatching should be pause.Calling
cursor.isCursorDataFullyPersistablewill loop the collectioncursor.individualDeletedMessages. It isnot a light method. If never enabled "dispatcherPauseOnAckStatePersistentEnabled", should avoid calling
cursor.isCursorDataFullyPersistable.Modifications
Avoid calling
cursor.isCursorDataFullyPersistableif disableddispatcherPauseOnAckStatePersistentEnabledDocumentation
docdoc-requireddoc-not-neededdoc-completeMatching PR in forked repository
PR in forked repository: x