-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[improve] [client] PIP-344 support feature flag supportsGetPartitionedMetadataWithoutAutoCreation #22773
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
codelipenghui
approved these changes
May 31, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, just left a minor comment.
pulsar-client/src/main/java/org/apache/pulsar/client/impl/BinaryProtoLookupService.java
Outdated
Show resolved
Hide resolved
/pulsarbot rerun-failure-checks |
RobertIndie
approved these changes
May 31, 2024
/pulsarbot rerun-failure-checks |
…dMetadataWithoutAutoCreation
poorbarcode
force-pushed
the
pip_344/part_2
branch
from
June 4, 2024 08:33
3102635
to
2136979
Compare
nikhil-ctds
pushed a commit
to datastax/pulsar
that referenced
this pull request
Jun 24, 2024
…dMetadataWithoutAutoCreation (apache#22773) (cherry picked from commit 6236116) (cherry picked from commit 03c0975)
nikhil-ctds
pushed a commit
to datastax/pulsar
that referenced
this pull request
Jun 24, 2024
…dMetadataWithoutAutoCreation (apache#22773) (cherry picked from commit 6236116) (cherry picked from commit 03c0975)
nikhil-ctds
pushed a commit
to datastax/pulsar
that referenced
this pull request
Jun 24, 2024
…dMetadataWithoutAutoCreation (apache#22773) (cherry picked from commit 6236116) (cherry picked from commit 03c0975)
nikhil-ctds
pushed a commit
to datastax/pulsar
that referenced
this pull request
Jun 25, 2024
…dMetadataWithoutAutoCreation (apache#22773) (cherry picked from commit 6236116) (cherry picked from commit 03c0975)
srinath-ctds
pushed a commit
to datastax/pulsar
that referenced
this pull request
Jul 1, 2024
…dMetadataWithoutAutoCreation (apache#22773) (cherry picked from commit 6236116) (cherry picked from commit 03c0975)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
cherry-picked/branch-3.0
cherry-picked/branch-3.3
doc-not-needed
Your PR changes do not impact docs
ready-to-test
release/3.0.6
release/3.3.1
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation & Modifications
PIP-344 Correct the behavior of the public API pulsarClient.getPartitionsForTopic(topicName)
Section Backward & Forward Compatibility
Old version client and New version Broker: The client will call the old API.
New version client and Old version Broker: The feature flag
supports_binary_api_get_partitioned_meta_with_param_created_false
will befalse
. The client will get a not-support error if the paramcreateIfAutoCreationEnabled
isfalse
.Documentation
doc
doc-required
doc-not-needed
doc-complete
Matching PR in forked repository
PR in forked repository: x