-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[improve][broker] Remove ClassLoaderSwitcher to avoid objects allocations and consistent the codestyle #22796
[improve][broker] Remove ClassLoaderSwitcher to avoid objects allocations and consistent the codestyle #22796
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
+1
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #22796 +/- ##
============================================
- Coverage 73.57% 73.22% -0.35%
Complexity 32624 32624
============================================
Files 1877 1890 +13
Lines 139502 141628 +2126
Branches 15299 15540 +241
============================================
+ Hits 102638 103708 +1070
- Misses 28908 29928 +1020
- Partials 7956 7992 +36
Flags with carried forward coverage won't be shown. Click here to find out more.
|
Object allocations are not a big deal here. The main purpose is that you wanna align the code style, right? |
Yes, Protocol handler and AdditionalServlet is not in the message publish/consume calling chain, and they don't call frequently, the PR just consistent the codestyle. |
merging.. |
…ions and consistent the codestyle (#22796)
…ions and consistent the codestyle (#22796)
…ions and consistent the codestyle (apache#22796) (cherry picked from commit 7918ed5)
…ions and consistent the codestyle (apache#22796) (cherry picked from commit 7918ed5)
…ions and consistent the codestyle (apache#22796) (cherry picked from commit 7918ed5)
…ions and consistent the codestyle (#22796)
…ions and consistent the codestyle (apache#22796) (cherry picked from commit 7918ed5)
Motivation
Apply #22790 's pattern and address the comment #22767 (comment)
Modifications
Verifying this change
(Please pick either of the following options)
This change is a trivial rework / code cleanup without any test coverage.
(or)
This change is already covered by existing tests, such as (please describe tests).
(or)
This change added tests and can be verified as follows:
(example:)
Does this pull request potentially affect one of the following parts:
If the box was checked, please highlight the changes
Documentation
doc
doc-required
doc-not-needed
doc-complete
Matching PR in forked repository
PR in forked repository: