Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[fix][cli] Fix healthcheck script pulsar-zookeeper-ruok.sh #22873

Merged

Conversation

lhotari
Copy link
Member

@lhotari lhotari commented Jun 7, 2024

Fixes #22872

Motivation

pulsar-zookeeper-ruok.sh script doesn't work in the latest apachepulsar/pulsar:3.3.0 image.

Modifications

  • make the script compatible with Alpine's default busybox nc (so that it isn't necessary to install netcat-openbsd)
    • replace "-q 1" with "sleep 1" in the input
    • replace "localhost" with "127.0.0.1" (so that IPv4 gets selected?)

Documentation

  • doc
  • doc-required
  • doc-not-needed
  • doc-complete

- make it compatible with Alpine's default busybox nc
  - replace "-q 1" with "sleep 1"
@lhotari lhotari self-assigned this Jun 7, 2024
@lhotari lhotari requested review from merlimat and codelipenghui June 7, 2024 15:11
@lhotari lhotari added this to the 3.4.0 milestone Jun 7, 2024
@github-actions github-actions bot added the doc-not-needed Your PR changes do not impact docs label Jun 7, 2024
@lhotari lhotari added release/3.3.1 and removed doc-not-needed Your PR changes do not impact docs labels Jun 7, 2024
@github-actions github-actions bot added the doc-not-needed Your PR changes do not impact docs label Jun 7, 2024
@lhotari lhotari marked this pull request as draft June 7, 2024 15:35
@lhotari
Copy link
Member Author

lhotari commented Jun 7, 2024

I'm verifying a similar solution in apache/pulsar-helm-chart#504. However there's some issue although I tested the solution in docker. I'll verify in k8s too.

@lhotari lhotari marked this pull request as ready for review June 7, 2024 16:28
@lhotari
Copy link
Member Author

lhotari commented Jun 7, 2024

The problem in Apache Pulsar Helm chart is unrelated to the healthcheck. It works now with this syntax. There's some other DNS lookup related issue with the Alpine image. Something that could be possibly resolved with a ndots: 5 config. I'll investigate.

@lhotari lhotari merged commit 80d1cf9 into apache:master Jun 7, 2024
53 of 55 checks passed
@lhotari
Copy link
Member Author

lhotari commented Jun 7, 2024

Created #22877 and #22878 to address the nslookup issue.

lhotari added a commit that referenced this pull request Jun 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug] bin/pulsar-zookeeper-ruok.sh fails with apachepulsar/pulsar:3.3.0 image
2 participants