[improve][build] Require Java 17 or Java 21 for building Pulsar #22875
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
heesung-sn
approved these changes
Jun 7, 2024
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #22875 +/- ##
============================================
- Coverage 73.57% 73.26% -0.32%
- Complexity 32624 32680 +56
============================================
Files 1877 1889 +12
Lines 139502 141871 +2369
Branches 15299 15565 +266
============================================
+ Hits 102638 103941 +1303
- Misses 28908 29898 +990
- Partials 7956 8032 +76
Flags with carried forward coverage won't be shown. Click here to find out more. |
lhotari
added a commit
that referenced
this pull request
Oct 4, 2024
(cherry picked from commit e31dbdd)
lhotari
added a commit
that referenced
this pull request
Oct 4, 2024
|
In branch-3.0, the rule is to require Java 17 exactly (ad935a0) since certain libraries in branch-3.0 don't support compiling with Java 21. Compiling with Java 21 is supported and preferred since branch-3.3 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #22874
Motivation
Building Pulsar is supported with either Java 17 or Java 21. This should be enforced so that there's a clear error message when the build is run on an unsupported Java version.
Modifications
Change the version range for enforcer plugin to allow all Java 17 versions and all Java 21 versions.
Documentation
docdoc-requireddoc-not-neededdoc-complete