Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[fix][cli] Fix the pulsar-daemon parameter passthrough syntax #22905

Merged
merged 2 commits into from
Jun 14, 2024
Merged

[fix][cli] Fix the pulsar-daemon parameter passthrough syntax #22905

merged 2 commits into from
Jun 14, 2024

Conversation

coderzc
Copy link
Member

@coderzc coderzc commented Jun 14, 2024 •
edited by Technoboy-
Loading

Motivation

Using bin/pulsar-daemon start standalone can't start pulsar due to #22867 changing bin/pulsar parameter passthrough syntax.

Modifications

replace "$1" with "$@" in bin/pulsar

Verifying this change

  • Make sure that the change passes the CI checks.

(Please pick either of the following options)

This change is a trivial rework / code cleanup without any test coverage.

(or)

This change is already covered by existing tests, such as (please describe tests).

(or)

This change added tests and can be verified as follows:

(example:)

  • Added integration tests for end-to-end deployment with large payloads (10MB)
  • Extended integration test for recovery after broker failure

Does this pull request potentially affect one of the following parts:

If the box was checked, please highlight the changes

  • Dependencies (add or upgrade a dependency)
  • The public API
  • The schema
  • The default values of configurations
  • The threading model
  • The binary protocol
  • The REST endpoints
  • The admin CLI options
  • The metrics
  • Anything that affects deployment

Documentation

  • doc
  • doc-required
  • doc-not-needed
  • doc-complete

Matching PR in forked repository

PR in forked repository:

@github-actions github-actions bot added the doc-not-needed Your PR changes do not impact docs label Jun 14, 2024
@coderzc coderzc requested a review from lhotari June 14, 2024 05:15
lhotari
lhotari requested changes Jun 14, 2024
View reviewed changes
bin/pulsar-daemon Outdated Show resolved Hide resolved
@Technoboy- Technoboy- added this to the 3.4.0 milestone Jun 14, 2024
@coderzc coderzc added release/3.3.1 release/3.0.6 type/bug The PR fixed a bug or issue reported a bug area/cli labels Jun 14, 2024
@coderzc coderzc merged commit 7a21918 into apache:master Jun 14, 2024
50 of 55 checks passed
coderzc added a commit that referenced this pull request Jun 14, 2024
@coderzc
[fix][cli] Fix the pulsar-daemon parameter passthrough syntax (#22905)
dfd7503 
Co-authored-by: Lari Hotari <lhotari@apache.org>
(cherry picked from commit 7a21918)
coderzc added a commit that referenced this pull request Jun 14, 2024
@coderzc
[fix][cli] Fix the pulsar-daemon parameter passthrough syntax (#22905)
2bb0e9f 
Co-authored-by: Lari Hotari <lhotari@apache.org>
(cherry picked from commit 7a21918)
coderzc added a commit that referenced this pull request Jun 14, 2024
@coderzc
[fix][cli] Fix the pulsar-daemon parameter passthrough syntax (#22905)
d34f522 
Co-authored-by: Lari Hotari <lhotari@apache.org>
(cherry picked from commit 7a21918)
nikhil-ctds pushed a commit to datastax/pulsar that referenced this pull request Jun 17, 2024
@coderzc @nikhil-ctds
[fix][cli] Fix the pulsar-daemon parameter passthrough syntax (apache…
e2c4f32 
…#22905)

Co-authored-by: Lari Hotari <lhotari@apache.org>
(cherry picked from commit 7a21918)
(cherry picked from commit d34f522)
nikhil-ctds pushed a commit to datastax/pulsar that referenced this pull request Jun 25, 2024
@coderzc @nikhil-ctds
[fix][cli] Fix the pulsar-daemon parameter passthrough syntax (apache…
81f9bf7 
…#22905)

Co-authored-by: Lari Hotari <lhotari@apache.org>
(cherry picked from commit 7a21918)
(cherry picked from commit d34f522)
srinath-ctds pushed a commit to datastax/pulsar that referenced this pull request Jul 1, 2024
@coderzc @srinath-ctds
[fix][cli] Fix the pulsar-daemon parameter passthrough syntax (apache…
ee21988 
…#22905)

Co-authored-by: Lari Hotari <lhotari@apache.org>
(cherry picked from commit 7a21918)
(cherry picked from commit d34f522)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shibd shibd shibd approved these changes

@Technoboy- Technoboy- Technoboy- approved these changes

@lhotari lhotari lhotari approved these changes

Assignees

@coderzc coderzc

Labels
area/cli cherry-picked/branch-3.0 cherry-picked/branch-3.2 cherry-picked/branch-3.3 doc-not-needed Your PR changes do not impact docs release/3.0.6 release/3.2.4 release/3.3.1 type/bug The PR fixed a bug or issue reported a bug
Projects
None yet
Milestone
4.0.0
Development

Successfully merging this pull request may close these issues.
4 participants
@coderzc @lhotari @Technoboy- @shibd