Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[fix][broker] Update init and shutdown time and other minor logic (ExtensibleLoadManagerImpl only) #22930

Merged
merged 1 commit into from
Jun 18, 2024
Merged

[fix][broker] Update init and shutdown time and other minor logic (ExtensibleLoadManagerImpl only) #22930

merged 1 commit into from
Jun 18, 2024

Conversation

heesung-sn
Copy link
Contributor

@heesung-sn heesung-sn commented Jun 18, 2024 •
edited
Loading

Motivation

Found that init and shutdown time and other minor logic could be further improved.

Modifications

  • remove OWNERSHIP_CLEAN_UP_CONVERGENCE_DELAY_IN_MILLIS
  • pass timeout var to unloadNamespaceBundleAsync
  • pass the default bundle config when creating system namespace
  • check the channel ownership before running the broker cleanup
  • put timeout when init broker/bundle load store
  • run cleanUnloadedTopicFromCache when bundle unload fails when disconnectClients = false

Verifying this change

  • Make sure that the change passes the CI checks.

Does this pull request potentially affect one of the following parts:

If the box was checked, please highlight the changes

  • Dependencies (add or upgrade a dependency)
  • The public API
  • The schema
  • The default values of configurations
  • The threading model
  • The binary protocol
  • The REST endpoints
  • The admin CLI options
  • The metrics
  • Anything that affects deployment

Documentation

  • doc
  • doc-required
  • doc-not-needed
  • doc-complete

Matching PR in forked repository

PR in forked repository:

@github-actions github-actions bot added the doc-not-needed Your PR changes do not impact docs label Jun 18, 2024
@BewareMyPower BewareMyPower added this to the 3.4.0 milestone Jun 18, 2024
@BewareMyPower BewareMyPower added type/enhancement The enhancements for the existing features or docs. e.g. reduce memory usage of the delayed messages ready-to-test labels Jun 18, 2024
@heesung-sn heesung-sn merged commit aa8f696 into apache:master Jun 18, 2024
56 of 64 checks passed
@heesung-sn heesung-sn deleted the ExtensibleLoadManagerImpl-init-time branch June 18, 2024 15:44
@lhotari
Copy link
Member

lhotari commented Jun 19, 2024

@heesung-sn Please handle the cherry-picking since there are merge conflicts in both branch-3.0 and branch-3.3.

@lhotari
Copy link
Member

lhotari commented Jun 19, 2024

Is there a specific reason to skip branch-3.2 ? That branch is still maintained.

heesung-sn added a commit to heesung-sn/pulsar that referenced this pull request Jun 26, 2024
@heesung-sn
[fix][broker] Update init and shutdown time and other minor logic (Ex…
9babb8f 
…tensibleLoadManagerImpl only) (apache#22930)

(cherry picked from commit aa8f696)
heesung-sn added a commit to heesung-sn/pulsar that referenced this pull request Jun 26, 2024
@heesung-sn
[fix][broker] Update init and shutdown time and other minor logic (Ex…
9b6156a 
…tensibleLoadManagerImpl only) (apache#22930)

(cherry picked from commit aa8f696)
heesung-sn added a commit to heesung-sn/pulsar that referenced this pull request Jun 26, 2024
@heesung-sn
[fix][broker] Update init and shutdown time and other minor logic (Ex…
1c6018a 
…tensibleLoadManagerImpl only) (apache#22930)

(cherry picked from commit aa8f696)
(cherry picked from commit 9b6156a)
heesung-sn added a commit to heesung-sn/pulsar that referenced this pull request Jun 26, 2024
@heesung-sn
[fix][broker] Update init and shutdown time and other minor logic (Ex…
f77e05b 
…tensibleLoadManagerImpl only) (apache#22930)

(cherry picked from commit aa8f696)
heesung-sn added a commit to heesung-sn/pulsar that referenced this pull request Jun 26, 2024
@heesung-sn
[fix][broker] Update init and shutdown time and other minor logic (Ex…
77fd54e 
…tensibleLoadManagerImpl only) (apache#22930)

(cherry picked from commit aa8f696)
heesung-sn added a commit to heesung-sn/pulsar that referenced this pull request Jun 26, 2024
@heesung-sn
[fix][broker] Update init and shutdown time and other minor logic (Ex…
408c400 
…tensibleLoadManagerImpl only) (apache#22930)

(cherry picked from commit aa8f696)
heesung-sn added a commit to heesung-sn/pulsar that referenced this pull request Jun 26, 2024
@heesung-sn
[fix][broker] Update init and shutdown time and other minor logic (Ex…
f2cebcc 
…tensibleLoadManagerImpl only) (apache#22930)

(cherry picked from commit aa8f696)
(cherry picked from commit 9b6156a)
heesung-sn added a commit to heesung-sn/pulsar that referenced this pull request Jun 26, 2024
@heesung-sn
[fix][broker] Update init and shutdown time and other minor logic (Ex…
2b68458 
…tensibleLoadManagerImpl only) (apache#22930)

(cherry picked from commit aa8f696)
(cherry picked from commit 9b6156a)
heesung-sn added a commit to heesung-sn/pulsar that referenced this pull request Jun 26, 2024
@heesung-sn
[fix][broker] Update init and shutdown time and other minor logic (Ex…
c5be6cf 
…tensibleLoadManagerImpl only) (apache#22930)

(cherry picked from commit aa8f696)
heesung-sn added a commit to heesung-sn/pulsar that referenced this pull request Jun 27, 2024
@heesung-sn
[fix][broker] Update init and shutdown time and other minor logic (Ex…
d9c5132 
…tensibleLoadManagerImpl only) (apache#22930)

(cherry picked from commit aa8f696)
(cherry picked from commit 9b6156a)
nikhil-ctds pushed a commit to datastax/pulsar that referenced this pull request Jun 27, 2024
@heesung-sn @nikhil-ctds
[fix][broker] Update init and shutdown time and other minor logic (Ex…
36a0967 
…tensibleLoadManagerImpl only) (apache#22930)

(cherry picked from commit aa8f696)
(cherry picked from commit 9b6156a)
(cherry picked from commit d9c5132)
srinath-ctds pushed a commit to datastax/pulsar that referenced this pull request Jul 1, 2024
@heesung-sn @srinath-ctds
[fix][broker] Update init and shutdown time and other minor logic (Ex…
eeb084f 
…tensibleLoadManagerImpl only) (apache#22930)

(cherry picked from commit aa8f696)
(cherry picked from commit 9b6156a)
(cherry picked from commit d9c5132)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Demogorgon314 Demogorgon314 Demogorgon314 approved these changes

@BewareMyPower BewareMyPower BewareMyPower approved these changes

Assignees

@heesung-sn heesung-sn

Labels
cherry-picked/branch-3.0 cherry-picked/branch-3.2 cherry-picked/branch-3.3 doc-not-needed Your PR changes do not impact docs ready-to-test release/3.0.6 release/3.2.4 release/3.3.1 type/enhancement The enhancements for the existing features or docs. e.g. reduce memory usage of the delayed messages
Projects
None yet
Milestone
4.0.0
Development

Successfully merging this pull request may close these issues.
4 participants
@heesung-sn @lhotari @BewareMyPower @Demogorgon314