[fix][broker] Check the markDeletePosition and calculate the backlog #22947
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Zixuan Liu <nodeces@gmail.com>
nodece
requested review from
lhotari and
poorbarcode
and removed request for
lhotari
nodece
added
release/2.10.7
release/2.11.5
release/3.2.3
release/3.0.6
release/3.2.4
and removed
release/3.2.3
labels
dao-jun
approved these changes
Jun 20, 2024
Technoboy-
approved these changes
Jun 20, 2024
crossoverJie
approved these changes
Jun 20, 2024
nodece
added a commit
to ascentstream/pulsar
that referenced
this pull request
Jun 21, 2024
…pache#22947) Signed-off-by: Zixuan Liu <nodeces@gmail.com> (cherry picked from commit 82b8d98)
nikhil-ctds
pushed a commit
to datastax/pulsar
that referenced
this pull request
Jun 24, 2024
…pache#22947) Signed-off-by: Zixuan Liu <nodeces@gmail.com> (cherry picked from commit 82b8d98) (cherry picked from commit c0e1bff)
nikhil-ctds
pushed a commit
to datastax/pulsar
that referenced
this pull request
Jun 25, 2024
…pache#22947) Signed-off-by: Zixuan Liu <nodeces@gmail.com> (cherry picked from commit 82b8d98) (cherry picked from commit c0e1bff)
srinath-ctds
pushed a commit
to datastax/pulsar
that referenced
this pull request
Jul 1, 2024
…pache#22947) Signed-off-by: Zixuan Liu <nodeces@gmail.com> (cherry picked from commit 82b8d98) (cherry picked from commit c0e1bff)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
#21248 improves the backlog calculation.
When
isPreciseis false, sometimes it will fall back to the precise backlog count, if the mark delete position is greater than the last position, this will throw the invalid range:Modifications
Verifying this change
This PR encapsulates the code without changing its original behavior.
Documentation
docdoc-requireddoc-not-neededdoc-complete