Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[cleanup][misc] Remove classifier from netty-transport-native-unix-common dependency #22951

Merged

Conversation

lhotari
Copy link
Member

@lhotari lhotari commented Jun 20, 2024

Motivation

The unix-common with classifier dependency is optional because it is not a runtime dependency, but a build time dependency to get the static library which is built directly into the shared library generated by this project.

Modifications

  • remove classifier from netty-transport-native-unix-common dependency

Documentation

  • doc
  • doc-required
  • doc-not-needed
  • doc-complete

…mmon dependency

- explained in https://github.com/netty/netty/blob/217df76/transport-native-epoll/pom.xml#L208-L218:
  "The unix-common with classifier dependency is optional because it is not a runtime dependency, but a build time
   dependency to get the static library which is built directly into the shared library generated by this project."
@lhotari lhotari added this to the 3.4.0 milestone Jun 20, 2024
@lhotari lhotari self-assigned this Jun 20, 2024
@github-actions github-actions bot added the doc-not-needed Your PR changes do not impact docs label Jun 20, 2024
@lhotari lhotari merged commit 6692bc8 into apache:master Jun 20, 2024
48 of 54 checks passed
lhotari added a commit that referenced this pull request Jun 21, 2024
lhotari added a commit that referenced this pull request Jun 24, 2024
lhotari added a commit that referenced this pull request Jun 24, 2024
nikhil-ctds pushed a commit to datastax/pulsar that referenced this pull request Jun 27, 2024
…mmon dependency (apache#22951)

(cherry picked from commit 6692bc8)
(cherry picked from commit 2c11988)
nikhil-ctds pushed a commit to datastax/pulsar that referenced this pull request Jul 1, 2024
…mmon dependency (apache#22951)

(cherry picked from commit 6692bc8)
(cherry picked from commit 2c11988)
srinath-ctds pushed a commit to datastax/pulsar that referenced this pull request Jul 1, 2024
…mmon dependency (apache#22951)

(cherry picked from commit 6692bc8)
(cherry picked from commit 2c11988)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants