[fix][misc] Rename netty native libraries in pulsar-client-admin-shaded #22954
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lhotari
added
type/bug
lhotari
requested review from
merlimat,
Technoboy-,
eolivelli,
codelipenghui,
nodece,
BewareMyPower,
dao-jun,
poorbarcode and
heesung-sn
dao-jun
approved these changes
Jun 21, 2024
eolivelli
approved these changes
Jun 21, 2024
nikhil-ctds
pushed a commit
to datastax/pulsar
that referenced
this pull request
Jun 27, 2024
…ed (apache#22954) (cherry picked from commit ddb03bb) (cherry picked from commit a7d4e20)
nikhil-ctds
pushed a commit
to datastax/pulsar
that referenced
this pull request
Jun 27, 2024
…ed (apache#22954) (cherry picked from commit ddb03bb) (cherry picked from commit 07df550)
srinath-ctds
pushed a commit
to datastax/pulsar
that referenced
this pull request
Jul 1, 2024
…ed (apache#22954) (cherry picked from commit ddb03bb) (cherry picked from commit a7d4e20)
srinath-ctds
pushed a commit
to datastax/pulsar
that referenced
this pull request
Jul 1, 2024
…ed (apache#22954) (cherry picked from commit ddb03bb) (cherry picked from commit 07df550)
hanmz
pushed a commit
to hanmz/pulsar
that referenced
this pull request
Feb 12, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
It's necessary to rename the bundled Netty native libraries in the shaded jar file.
This has been done for pulsar-client and pulsar-client-all. Netty is also included in pulsar-client-admin-shaded and the renaming has been missing.
Modifications
pulsar-client-admin-shaded/pom.xmlAdditional information
Using pulsar-client-admin dependency might cause applications to crash if the application uses an older version of Netty or Netty Tcnative. The workaround to this issue (before the fix in this PR is released) is to use the shaded pulsar-client-all dependency (which includes both the Java client and the Admin client) instead of using pulsar-client-admin dependency.
Documentation
docdoc-requireddoc-not-neededdoc-complete