Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[fix][misc] Remove RoaringBitmap dependency from pulsar-common #23008

Merged

Conversation

lhotari
Copy link
Member

@lhotari lhotari commented Jul 8, 2024

Motivation

This is a follow-up to #23006

  • pulsar-common is also used by the client, a new dependency shouldn't be introduced without a reason.

Modifications

  • pass a supplier for creating the RoaringBitmap's RoaringBitSet. Add the RoaringBitmap dependency to managed-ledger module instead of pulsar-common.

Documentation

  • doc
  • doc-required
  • doc-not-needed
  • doc-complete

- pulsar-common is also used by the client, a new dependency shouldn't be introduced without a reason.
@lhotari lhotari added release/blocker Indicate the PR or issue that should block the release until it gets resolved ready-to-test release/3.3.1 release/3.0.6 release/3.2.4 labels Jul 8, 2024
@lhotari lhotari added this to the 3.4.0 milestone Jul 8, 2024
@lhotari lhotari requested a review from dao-jun July 8, 2024 07:17
@lhotari lhotari self-assigned this Jul 8, 2024
@github-actions github-actions bot added the doc-not-needed Your PR changes do not impact docs label Jul 8, 2024
@lhotari lhotari requested a review from shibd July 8, 2024 07:18
Copy link
Member

@dao-jun dao-jun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 73.44%. Comparing base (bbc6224) to head (c621c6e).
Report is 441 commits behind head on master.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff              @@
##             master   #23008      +/-   ##
============================================
- Coverage     73.57%   73.44%   -0.14%     
- Complexity    32624    33301     +677     
============================================
  Files          1877     1912      +35     
  Lines        139502   143198    +3696     
  Branches      15299    15590     +291     
============================================
+ Hits         102638   105170    +2532     
- Misses        28908    30018    +1110     
- Partials       7956     8010      +54     
Flag Coverage Δ
inttests 27.58% <66.66%> (+2.99%) ⬆️
systests 24.76% <66.66%> (+0.43%) ⬆️
unittests 72.50% <100.00%> (-0.35%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
...pache/bookkeeper/mledger/impl/RangeSetWrapper.java 94.33% <100.00%> (ø)
.../common/util/collections/OpenLongPairRangeSet.java 90.30% <100.00%> (ø)

... and 492 files with indirect coverage changes

@lhotari lhotari merged commit 32e29a3 into apache:master Jul 8, 2024
50 of 51 checks passed
lhotari added a commit that referenced this pull request Jul 8, 2024
lhotari added a commit that referenced this pull request Jul 8, 2024
lhotari added a commit that referenced this pull request Jul 8, 2024
nikhil-ctds pushed a commit to datastax/pulsar that referenced this pull request Jul 10, 2024
srinath-ctds pushed a commit to datastax/pulsar that referenced this pull request Jul 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants