-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[fix][misc] Remove RoaringBitmap dependency from pulsar-common #23008
Merged
lhotari
merged 2 commits into
apache:master
from
lhotari:lh-remove-roaringbitmap-dep-from-pulsar-common
Jul 8, 2024
Merged
[fix][misc] Remove RoaringBitmap dependency from pulsar-common #23008
lhotari
merged 2 commits into
apache:master
from
lhotari:lh-remove-roaringbitmap-dep-from-pulsar-common
Jul 8, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- pulsar-common is also used by the client, a new dependency shouldn't be introduced without a reason.
lhotari
added
release/blocker
Indicate the PR or issue that should block the release until it gets resolved
ready-to-test
release/3.3.1
release/3.0.6
release/3.2.4
labels
Jul 8, 2024
lhotari
requested review from
merlimat,
mattisonchao,
codelipenghui and
poorbarcode
July 8, 2024 07:18
crossoverJie
approved these changes
Jul 8, 2024
dao-jun
approved these changes
Jul 8, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
shibd
approved these changes
Jul 8, 2024
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #23008 +/- ##
============================================
- Coverage 73.57% 73.44% -0.14%
- Complexity 32624 33301 +677
============================================
Files 1877 1912 +35
Lines 139502 143198 +3696
Branches 15299 15590 +291
============================================
+ Hits 102638 105170 +2532
- Misses 28908 30018 +1110
- Partials 7956 8010 +54
Flags with carried forward coverage won't be shown. Click here to find out more.
|
lhotari
added a commit
that referenced
this pull request
Jul 8, 2024
(cherry picked from commit 32e29a3)
lhotari
added a commit
that referenced
this pull request
Jul 8, 2024
(cherry picked from commit 32e29a3)
lhotari
added a commit
that referenced
this pull request
Jul 8, 2024
(cherry picked from commit 32e29a3)
nikhil-ctds
pushed a commit
to datastax/pulsar
that referenced
this pull request
Jul 10, 2024
srinath-ctds
pushed a commit
to datastax/pulsar
that referenced
this pull request
Jul 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
cherry-picked/branch-3.0
cherry-picked/branch-3.2
cherry-picked/branch-3.3
doc-not-needed
Your PR changes do not impact docs
ready-to-test
release/blocker
Indicate the PR or issue that should block the release until it gets resolved
release/3.0.6
release/3.2.4
release/3.3.1
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
This is a follow-up to #23006
Modifications
Documentation
doc
doc-required
doc-not-needed
doc-complete