Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[improve][broker] PIP-366: Support to specify different config for Configuration and Local Metadata Store #23041

Conversation

Demogorgon314
Copy link
Member

@Demogorgon314 Demogorgon314 commented Jul 16, 2024

Motivation

Implementation PR for PIP: #23033.

Modifications

Support to specify different config for Configuration and Local Metadata Store in zk and oxia impl

Documentation

  • doc
  • doc-required
  • doc-not-needed
  • doc-complete

@Demogorgon314 Demogorgon314 self-assigned this Jul 16, 2024
@github-actions github-actions bot added the doc-not-needed Your PR changes do not impact docs label Jul 16, 2024
@Demogorgon314 Demogorgon314 force-pushed the Demogorgon314/Support-to-specify-different-config-for-Configuration-and-Local-Metadata-Store branch from 90775a2 to a10c79d Compare July 26, 2024 04:16
@Demogorgon314 Demogorgon314 changed the title [improve][pip] PIP-366: Support to specify different config for Configuration and Local Metadata Store zk impl [improve][pip] PIP-366: Support to specify different config for Configuration and Local Metadata Store Jul 26, 2024
Copy link
Contributor

@dragosvictor dragosvictor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@codecov-commenter
Copy link

codecov-commenter commented Aug 2, 2024

Codecov Report

Attention: Patch coverage is 85.71429% with 4 lines in your changes missing coverage. Please review.

Project coverage is 73.44%. Comparing base (bbc6224) to head (a10c79d).
Report is 774 commits behind head on master.

Files with missing lines Patch % Lines
...n/java/org/apache/pulsar/broker/PulsarService.java 50.00% 1 Missing and 1 partial ⚠️
...he/pulsar/metadata/impl/PulsarZooKeeperClient.java 80.00% 2 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff              @@
##             master   #23041      +/-   ##
============================================
- Coverage     73.57%   73.44%   -0.14%     
- Complexity    32624    33521     +897     
============================================
  Files          1877     1917      +40     
  Lines        139502   144082    +4580     
  Branches      15299    15744     +445     
============================================
+ Hits         102638   105819    +3181     
- Misses        28908    30152    +1244     
- Partials       7956     8111     +155     
Flag Coverage Δ
inttests 27.52% <64.28%> (+2.94%) ⬆️
systests 24.76% <35.71%> (+0.44%) ⬆️
unittests 72.52% <85.71%> (-0.33%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
...org/apache/pulsar/broker/ServiceConfiguration.java 99.03% <100.00%> (-0.37%) ⬇️
...g/apache/pulsar/metadata/impl/ZKMetadataStore.java 85.66% <100.00%> (+0.41%) ⬆️
...e/pulsar/metadata/impl/oxia/OxiaMetadataStore.java 87.67% <100.00%> (-2.33%) ⬇️
...n/java/org/apache/pulsar/broker/PulsarService.java 83.91% <50.00%> (+1.54%) ⬆️
...he/pulsar/metadata/impl/PulsarZooKeeperClient.java 42.43% <80.00%> (+0.70%) ⬆️

... and 513 files with indirect coverage changes

@Demogorgon314 Demogorgon314 merged commit 76f16e8 into apache:master Aug 5, 2024
62 of 63 checks passed
@Demogorgon314 Demogorgon314 deleted the Demogorgon314/Support-to-specify-different-config-for-Configuration-and-Local-Metadata-Store branch August 5, 2024 02:07
lhotari pushed a commit that referenced this pull request Aug 6, 2024
…guration and Local Metadata Store (#23041)

(cherry picked from commit 76f16e8)
Denovo1998 pushed a commit to Denovo1998/pulsar that referenced this pull request Aug 17, 2024
grssam pushed a commit to grssam/pulsar that referenced this pull request Sep 4, 2024
@lhotari lhotari added this to the 4.0.0 milestone Oct 14, 2024
@lhotari lhotari changed the title [improve][pip] PIP-366: Support to specify different config for Configuration and Local Metadata Store [improve][broker] PIP-366: Support to specify different config for Configuration and Local Metadata Store Oct 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants