Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[improve][broker][branch-3.0] PIP-364: Introduce a new load balance algorithm AvgShedder #23053

Merged
merged 1 commit into from
Jul 19, 2024

Conversation

thetumbled
Copy link
Member

Copy link

@thetumbled Please add the following content to your PR description and select a checkbox:

- [ ] `doc` <!-- Your PR contains doc changes -->
- [ ] `doc-required` <!-- Your PR changes impact docs and you will update later -->
- [ ] `doc-not-needed` <!-- Your PR changes do not impact docs -->
- [ ] `doc-complete` <!-- Docs have been already added -->

@thetumbled thetumbled requested a review from BewareMyPower July 19, 2024 03:28
@Demogorgon314 Demogorgon314 changed the title [cherry pick] [branch 3.0] PIP-364: Introduce a new load balance algorithm AvgShedder [improve][broker][branch-3.0] PIP-364: Introduce a new load balance algorithm AvgShedder Jul 19, 2024
@Demogorgon314 Demogorgon314 reopened this Jul 19, 2024
@Demogorgon314 Demogorgon314 added doc-not-needed Your PR changes do not impact docs and removed doc-label-missing labels Jul 19, 2024
@github-actions github-actions bot added doc-label-missing and removed doc-not-needed Your PR changes do not impact docs labels Jul 19, 2024
@thetumbled thetumbled merged commit 3bdd598 into apache:branch-3.0 Jul 19, 2024
45 of 70 checks passed
thetumbled added a commit that referenced this pull request Jul 19, 2024
thetumbled added a commit that referenced this pull request Jul 19, 2024
@thetumbled
Copy link
Member Author

thetumbled commented Jul 19, 2024

There is a CI can't passed in branch 3.0, could you help to take a look? @lhotari @dao-jun :

StreamingEntryReaderTests.testCanCancelReadEntryRequestAndResumeReading
Unfinished stubbing detected here:
-> at org.apache.pulsar.broker.service.streamingdispatch.StreamingEntryReaderTests.testCanCancelReadEntryRequestAndResumeReading(StreamingEntryReaderTests.java:286)

E.g. thenReturn() may be missing.
Examples of correct stubbing:
    when(mock.isOk()).thenReturn(true);
    when(mock.isOk()).thenThrow(exception);
    doThrow(exception).when(mock).someVoidMethod();
Hints:
 1. missing thenReturn()
 2. you are trying to stub a final method, which is not supported
 3. you are stubbing the behaviour of another mock inside before 'thenReturn' instruction is completed

nikhil-ctds pushed a commit to datastax/pulsar that referenced this pull request Jul 25, 2024
srinath-ctds pushed a commit to datastax/pulsar that referenced this pull request Jul 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants