Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[fix] [broker] fix compile error for PersistentStickyKeyDispatcherMultipleConsumers #23055

Merged
merged 1 commit into from
Jul 21, 2024

Conversation

poorbarcode
Copy link
Contributor

@poorbarcode poorbarcode commented Jul 19, 2024

Motivation

#21953 is an old PR, it depends on ConcurrentOpenLongPairRangeSet.java, but before #21953 was merged, the class ConcurrentOpenLongPairRangeSet has been removed.

https://github.com/apache/pulsar/actions/runs/10006362098/job/27658946408?pr=23052

Error:  /home/runner/work/pulsar/pulsar/pulsar-broker/src/main/java/org/apache/pulsar/broker/service/persistent/PersistentStickyKeyDispatcherMultipleConsumers.java:[61,49] cannot find symbol

Modifications

Just fix the compile error, if ConcurrentOpenLongPairRangeSet is needed to remove, please use a separate PR to improve it.

Documentation

  • doc
  • doc-required
  • doc-not-needed
  • doc-complete

Matching PR in forked repository

PR in forked repository: x

@poorbarcode poorbarcode self-assigned this Jul 19, 2024
@poorbarcode poorbarcode added this to the 3.4.0 milestone Jul 19, 2024
@github-actions github-actions bot added the doc-not-needed Your PR changes do not impact docs label Jul 19, 2024
@poorbarcode
Copy link
Contributor Author

/pulsarbot rerun-failure-checks

@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 50.00000% with 100 lines in your changes missing coverage. Please review.

Project coverage is 73.45%. Comparing base (bbc6224) to head (f1ccbaa).
Report is 457 commits behind head on master.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff              @@
##             master   #23055      +/-   ##
============================================
- Coverage     73.57%   73.45%   -0.12%     
- Complexity    32624    33476     +852     
============================================
  Files          1877     1915      +38     
  Lines        139502   143928    +4426     
  Branches      15299    15723     +424     
============================================
+ Hits         102638   105726    +3088     
- Misses        28908    30099    +1191     
- Partials       7956     8103     +147     
Flag Coverage Δ
inttests 27.81% <32.00%> (+3.23%) ⬆️
systests 24.71% <32.00%> (+0.39%) ⬆️
unittests 72.52% <50.00%> (-0.33%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
...il/collections/ConcurrentOpenLongPairRangeSet.java 50.00% <50.00%> (-40.50%) ⬇️

... and 509 files with indirect coverage changes

@BewareMyPower BewareMyPower merged commit c50f4af into apache:master Jul 21, 2024
60 of 61 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
doc-not-needed Your PR changes do not impact docs ready-to-test
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants