-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[fix][client] Fix timeout handling in Pulsar Admin client #23128
Merged
lhotari
merged 8 commits into
apache:master
from
lhotari:lh-fix-timeout-handling-in-pulsar-admin
Aug 7, 2024
Merged
[fix][client] Fix timeout handling in Pulsar Admin client #23128
lhotari
merged 8 commits into
apache:master
from
lhotari:lh-fix-timeout-handling-in-pulsar-admin
Aug 7, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lhotari
added
type/bug
The PR fixed a bug or issue reported a bug
ready-to-test
release/2.11.5
release/3.0.7
release/3.3.2
labels
Aug 6, 2024
lhotari
requested review from
Technoboy-,
nodece,
dao-jun,
poorbarcode and
mattisonchao
August 6, 2024 12:55
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #23128 +/- ##
============================================
+ Coverage 73.57% 74.55% +0.98%
- Complexity 32624 33558 +934
============================================
Files 1877 1919 +42
Lines 139502 144166 +4664
Branches 15299 15758 +459
============================================
+ Hits 102638 107483 +4845
+ Misses 28908 28448 -460
- Partials 7956 8235 +279
Flags with carried forward coverage won't be shown. Click here to find out more.
|
Technoboy-
approved these changes
Aug 7, 2024
lhotari
added a commit
that referenced
this pull request
Aug 7, 2024
(cherry picked from commit 3b01c96)
lhotari
added a commit
that referenced
this pull request
Aug 7, 2024
(cherry picked from commit 3b01c96)
lhotari
added a commit
that referenced
this pull request
Aug 8, 2024
Denovo1998
pushed a commit
to Denovo1998/pulsar
that referenced
this pull request
Aug 17, 2024
4 tasks
grssam
pushed a commit
to grssam/pulsar
that referenced
this pull request
Sep 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
cherry-picked/branch-2.11
cherry-picked/branch-3.0
cherry-picked/branch-3.3
doc-not-needed
Your PR changes do not impact docs
ready-to-test
release/2.11.5
release/3.0.7
release/3.3.2
type/bug
The PR fixed a bug or issue reported a bug
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #23127
Motivation
In Pulsar Admin client, the read timeout is used as the request timeout. A read timeout is supposed to handle the case where the client doesn't receive any data and the connection is idle for more than the read timeout value.
Modifications
Documentation
doc
doc-required
doc-not-needed
doc-complete