[improve] [client]Add new ServiceUrlProvider implementation: SameAuthParamsAutoClusterFailover #23129
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ParamsAutoClusterFailover
|
/pulsarbot rerun-failure-checks |
congbobo184
approved these changes
Aug 7, 2024
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #23129 +/- ##
============================================
+ Coverage 73.57% 74.52% +0.95%
- Complexity 32624 33624 +1000
============================================
Files 1877 1920 +43
Lines 139502 144430 +4928
Branches 15299 15804 +505
============================================
+ Hits 102638 107637 +4999
+ Misses 28908 28534 -374
- Partials 7956 8259 +303
Flags with carried forward coverage won't be shown. Click here to find out more.
|
guan46
approved these changes
Aug 12, 2024
lhotari
reviewed
Aug 14, 2024
| PersistentTopicInternalStats internalStats = admin.topics().getInternalStats(topicName); | ||
| ManagedLedgerInternalStats.CursorStats cursorStats2 = internalStats.cursors.get("s2"); | ||
| String[] ledgerIdAndEntryId2 = cursorStats2.markDeletePosition.split(":"); | ||
| ImmutablePositionImpl actMarkDeletedPos2 = |
There was a problem hiding this comment.
There shouldn't be a need to use ImmutablePositionImpl in code. Simply use Position as the type and PositionFactory to create instances. They will be immutable by default.
There was a problem hiding this comment.
Created a new PR to revert it
lhotari
reviewed
Aug 14, 2024
| log.info("Expected mark deleted position: {}", expectedMarkDeletedPos); | ||
| log.info("Actual mark deleted position: {}", cursorStats.markDeletePosition); | ||
| assertTrue(actMarkDeletedPos.compareTo(expectedMarkDeletedPos) >= 0); | ||
| AssertJUnit.assertTrue(actMarkDeletedPos.compareTo(expectedMarkDeletedPos) >= 0); |
There was a problem hiding this comment.
AssertJUnit shouldn't be needed
There was a problem hiding this comment.
Created a new PR to revert it
lhotari
reviewed
Aug 14, 2024
There was a problem hiding this comment.
What is the purpose of this test in this PR? Is it unrelated?
There was a problem hiding this comment.
Created a new PR to revert it
4 tasks
nikhil-ctds
pushed a commit
to datastax/pulsar
that referenced
this pull request
Aug 16, 2024
…ParamsAutoClusterFailover (apache#23129) - excluding changes to pulsar-broker/src/test/java/org/apache/pulsar/client/api/NonDurableSubscriptionTest.java PR apache#23168 (cherry picked from commit 06a2f5c) (cherry picked from commit 286a5dc)
nikhil-ctds
pushed a commit
to datastax/pulsar
that referenced
this pull request
Aug 16, 2024
…ParamsAutoClusterFailover (apache#23129) - excluding changes to pulsar-broker/src/test/java/org/apache/pulsar/client/api/NonDurableSubscriptionTest.java PR apache#23168 (cherry picked from commit 06a2f5c) (cherry picked from commit 286a5dc)
srinath-ctds
pushed a commit
to datastax/pulsar
that referenced
this pull request
Aug 20, 2024
…ParamsAutoClusterFailover (apache#23129) - excluding changes to pulsar-broker/src/test/java/org/apache/pulsar/client/api/NonDurableSubscriptionTest.java PR apache#23168 (cherry picked from commit 06a2f5c) (cherry picked from commit 286a5dc)
Technoboy-
pushed a commit
that referenced
this pull request
Aug 22, 2024
…ParamsAutoClusterFailover (#23129)
grssam
pushed a commit
to grssam/pulsar
that referenced
this pull request
Sep 4, 2024
…ParamsAutoClusterFailover (apache#23129)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Background
So far, there are two implementations of
ServiceUrlProviderControlledClusterFailover: call an HTTP API to change the pulsar service URL.AutoClusterFailover: check the pulsar service URL by creating a socket, and automatically switch to the high-priority pulsar service URL.Issue
c1andc2, and start a binary-way replication between them.AutoClusterFailoverfor our client to switch connections to the healthy cluster when the primary one can not work.client -> proxy -> brokersIf all the brokers crash, the proxies are still healthy,
AutoClusterFailovercan not determine that the primary cluster can not provide service anymore.Modifications
Add a new ServiceUrlProvider implementation:
SameAuthParamsAutoClusterFailover, which useslookup topicto check whether the target cluster is healthy or not. Since the clusters that enabled Geo-Replication always have the same auth settings, it can be easy to implement(skipping the different auth settings ).Documentation
docdoc-requireddoc-not-neededdoc-completeMatching PR in forked repository
PR in forked repository: x