[fix][broker] Fix AvgShedder strategy check

[Demogorgon314]

Motivation

The check for AvgShedder strategy is wrong, we should use loadBalancerLoadPlacementStrategy instead of loadBalancerPlacementStrategy.

The loadBalancerPlacementStrategy is used by SimpleLoadManagerImpl, and it is deprecated.

Modifications

Use loadBalancerLoadPlacementStrategy instead of loadBalancerPlacementStrategy to check the AvgShedder strategy

Documentation

• doc
• doc-required
• doc-not-needed
• doc-complete

[heesung-sn]

Do you know Why we have these two similar configs? This is confusing indeed.

[Demogorgon314]

@heesung-sn The loadBalancerPlacementStrategy is used by SimpleLoadManagerImpl, and it is deprecated.

[codecov-commenter]

Codecov Report

Attention: Patch coverage is 0% with 2 lines in your changes missing coverage. Please review.

Project coverage is 74.53%. Comparing base (bbc6224) to head (d699090).
Report is 780 commits behind head on master.

Files with missing lines	Patch %	Lines
...roker/loadbalance/impl/ModularLoadManagerImpl.java	0.00%	2 Missing ⚠️

Additional details and impacted files

@@             Coverage Diff              @@
##             master   #23156      +/-   ##
============================================
+ Coverage     73.57%   74.53%   +0.96%     
- Complexity    32624    34102    +1478     
============================================
  Files          1877     1919      +42     
  Lines        139502   144269    +4767     
  Branches      15299    15778     +479     
============================================
+ Hits         102638   107533    +4895     
+ Misses        28908    28502     -406     
- Partials       7956     8234     +278     

Flag	Coverage Δ
inttests	27.62% <0.00%> (+3.04%)	⬆️
systests	24.79% <0.00%> (+0.47%)	⬆️
unittests	73.87% <0.00%> (+1.03%)	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines	Coverage Δ
...roker/loadbalance/impl/ModularLoadManagerImpl.java	84.32% <0.00%> (-0.67%)	⬇️

... and 488 files with indirect coverage changes

[thetumbled]

LGTM.

[thetumbled]

This bug fix is not included into branch 3.0, 3.2 and 3.3, we need to cherry pick it into 3.0 and 3.3 and wait for next release. @heesung-sn @Demogorgon314 @lhotari

[lhotari]

This bug fix is not included into branch 3.0, 3.2 and 3.3, we need to cherry pick it into 3.0 and 3.3 and wait for next release. @heesung-sn @Demogorgon314 @lhotari

The person merging the PR should ensure that the release labels are on the PR before it gets merged. That's how the release manager knows what it planned for a release. @thetumbled Please find the information in this email: https://lists.apache.org/thread/ryyfv8o33yyw9hmo5gnxn71boocn3mzs . This information is currently missing from our contribution guide.

[lhotari]

@thetumbled The cherry-picking process is now documented in https://pulsar.apache.org/contribute/maintenance-process/