Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[fix][test] Fix flaky SubscriptionSeekTest.testSeekIsByReceive #23170

Merged
merged 1 commit into from
Aug 16, 2024
Merged

[fix][test] Fix flaky SubscriptionSeekTest.testSeekIsByReceive #23170

merged 1 commit into from
Aug 16, 2024

Conversation

lhotari
Copy link
Member

@lhotari lhotari commented Aug 14, 2024

Motivation

The test SubscriptionSeekTest won't pass unless retries are enabled.

reproducing the issue:

mvn -DredirectTestOutputToFile=false -DtestRetryCount=0 test -pl pulsar-broker -Dtest=SubscriptionSeekTest

The test doesn't close consumers between test methods and that's why each method needs a unique topic.

Modifications

  • use unique topic name for testSeekIsByReceive method to prevent collisions
  • close producers and consumers between test methods

Documentation

  • doc
  • doc-required
  • doc-not-needed
  • doc-complete

@lhotari lhotari added this to the 4.0.0 milestone Aug 14, 2024
@lhotari lhotari self-assigned this Aug 14, 2024
@github-actions github-actions bot added the doc-not-needed Your PR changes do not impact docs label Aug 14, 2024
@lhotari lhotari requested review from dao-jun and shibd August 15, 2024 18:46
@nodece nodece merged commit a1f3322 into apache:master Aug 16, 2024
59 of 60 checks passed
lhotari added a commit that referenced this pull request Aug 16, 2024
@lhotari
[fix][test] Fix flaky SubscriptionSeekTest.testSeekIsByReceive (#23170)
67e89ce 
(cherry picked from commit a1f3322)
lhotari added a commit that referenced this pull request Aug 16, 2024
@lhotari
[fix][test] Fix flaky SubscriptionSeekTest.testSeekIsByReceive (#23170)
6434d57 
(cherry picked from commit a1f3322)
nikhil-ctds pushed a commit to datastax/pulsar that referenced this pull request Aug 22, 2024
@lhotari @nikhil-ctds
[fix][test] Fix flaky SubscriptionSeekTest.testSeekIsByReceive (apach…
52f7d84 
…e#23170)

(cherry picked from commit a1f3322)
(cherry picked from commit 6434d57)
srinath-ctds pushed a commit to datastax/pulsar that referenced this pull request Aug 23, 2024
@lhotari @srinath-ctds
[fix][test] Fix flaky SubscriptionSeekTest.testSeekIsByReceive (apach…
b463ba4 
…e#23170)

(cherry picked from commit a1f3322)
(cherry picked from commit 6434d57)
grssam pushed a commit to grssam/pulsar that referenced this pull request Sep 4, 2024
@lhotari @grssam
[fix][test] Fix flaky SubscriptionSeekTest.testSeekIsByReceive (apach…
b16a6a5 
…e#23170)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dao-jun dao-jun dao-jun approved these changes

@Technoboy- Technoboy- Awaiting requested review from Technoboy-

@poorbarcode poorbarcode Awaiting requested review from poorbarcode

@shibd shibd Awaiting requested review from shibd

Assignees

@lhotari lhotari

Labels
cherry-picked/branch-3.0 cherry-picked/branch-3.3 doc-not-needed Your PR changes do not impact docs ready-to-test release/3.0.7 release/3.3.2
Projects
None yet
Milestone
4.0.0
Development

Successfully merging this pull request may close these issues.
3 participants
@lhotari @dao-jun @nodece