[fix] [broker] Topic can never be loaded up due to broker maintains a failed topic creation future #23184
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… failed topic creation future
poorbarcode
requested review from
lhotari,
Technoboy-,
codelipenghui and
shibd
lhotari
reviewed
Aug 16, 2024
pulsar-broker/src/main/java/org/apache/pulsar/broker/service/BrokerService.java
Outdated
Show resolved
Hide resolved
shibd
approved these changes
Aug 17, 2024
nikhil-ctds
pushed a commit
to datastax/pulsar
that referenced
this pull request
Aug 22, 2024
… failed topic creation future (apache#23184) (cherry picked from commit 9edaa85) (cherry picked from commit 34c6fa0)
srinath-ctds
pushed a commit
to datastax/pulsar
that referenced
this pull request
Aug 23, 2024
… failed topic creation future (apache#23184) (cherry picked from commit 9edaa85) (cherry picked from commit 34c6fa0)
grssam
pushed a commit
to grssam/pulsar
that referenced
this pull request
Sep 4, 2024
… failed topic creation future (apache#23184)
nodece
pushed a commit
to ascentstream/pulsar
that referenced
this pull request
Sep 4, 2024
… failed topic creation future (apache#23184) (cherry picked from commit 9edaa85) Signed-off-by: Zixuan Liu <nodeces@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
There are two scenarios that may leave a failed topic creation future in
brokerService.topicsbecause forgot to remove the failed future from the map, which leads to the topic never being loaded up successfully.testTopicLoadAndDeleteAtTheSameTimetestCheckOwnerShipFailsModifications
Remove the failed future if load topic fails
Documentation
docdoc-requireddoc-not-neededdoc-completeMatching PR in forked repository
PR in forked repository: x