[improve] [broker] Optimize performance for checking max topics when the topic is a system topic #23185
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…the topic is a system topic
poorbarcode
changed the title
lhotari
approved these changes
Aug 16, 2024
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #23185 +/- ##
============================================
+ Coverage 73.57% 74.59% +1.01%
- Complexity 32624 33672 +1048
============================================
Files 1877 1921 +44
Lines 139502 144488 +4986
Branches 15299 15809 +510
============================================
+ Hits 102638 107777 +5139
+ Misses 28908 28471 -437
- Partials 7956 8240 +284
Flags with carried forward coverage won't be shown. Click here to find out more.
|
nikhil-ctds
pushed a commit
to datastax/pulsar
that referenced
this pull request
Aug 22, 2024
…the topic is a system topic (apache#23185) (cherry picked from commit 73433cd) (cherry picked from commit 09bc877)
srinath-ctds
pushed a commit
to datastax/pulsar
that referenced
this pull request
Aug 23, 2024
…the topic is a system topic (apache#23185) (cherry picked from commit 73433cd) (cherry picked from commit 09bc877)
grssam
pushed a commit
to grssam/pulsar
that referenced
this pull request
Sep 4, 2024
…the topic is a system topic (apache#23185)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation & Modifications
When loading the system topic, skip the check of
checkMaxTopicsPerNamespaceat the first line, it can let the system topic__change_eventstart faster and avoid thread switching.Documentation
docdoc-requireddoc-not-neededdoc-completeMatching PR in forked repository
PR in forked repository: x