[fix] [log] Do not print warn log when concurrently publishing and switching ledgers #23209
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4 tasks
|
It's necessary to cherry-pick to the branches where #22221 exists. |
dao-jun
approved these changes
Aug 21, 2024
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #23209 +/- ##
============================================
+ Coverage 73.57% 74.52% +0.94%
- Complexity 32624 33656 +1032
============================================
Files 1877 1918 +41
Lines 139502 144628 +5126
Branches 15299 15812 +513
============================================
+ Hits 102638 107781 +5143
+ Misses 28908 28588 -320
- Partials 7956 8259 +303
Flags with carried forward coverage won't be shown. Click here to find out more.
|
liudezhi2098
approved these changes
Aug 22, 2024
nikhil-ctds
pushed a commit
to datastax/pulsar
that referenced
this pull request
Aug 22, 2024
…itching ledgers (apache#23209) (cherry picked from commit 0a5cb51) (cherry picked from commit 57b0ca4)
srinath-ctds
pushed a commit
to datastax/pulsar
that referenced
this pull request
Aug 23, 2024
…itching ledgers (apache#23209) (cherry picked from commit 0a5cb51) (cherry picked from commit 57b0ca4)
grssam
pushed a commit
to grssam/pulsar
that referenced
this pull request
Sep 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #23208
Main Issue: #23208
Motivation & Modifications
When
publishingandledger switchingexecute concurrently, the broker will print a warn-level logAn OpAddEntry's ledger is empty., but it should not be awarnlevel. The testtestConcurrentlyOfPublishAndSwitchLedgercan reproduce the warning log printing.Documentation
docdoc-requireddoc-not-neededdoc-completeMatching PR in forked repository
PR in forked repository: x