-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[improve][client] Enhance error handling for non-exist subscription in consumer creation #23254
Merged
lhotari
merged 1 commit into
apache:master
from
Shawyeok:fix/throw-semantic-exception-when-subscription-not-exist
Nov 29, 2024
Merged
[improve][client] Enhance error handling for non-exist subscription in consumer creation #23254
lhotari
merged 1 commit into
apache:master
from
Shawyeok:fix/throw-semantic-exception-when-subscription-not-exist
Nov 29, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…r and subscription not exist
lhotari
approved these changes
Oct 9, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Technoboy-
approved these changes
Nov 20, 2024
nikhil-ctds
pushed a commit
to datastax/pulsar
that referenced
this pull request
Dec 6, 2024
…n consumer creation (apache#23254) (cherry picked from commit 7fc88d6) (cherry picked from commit 5dec2e2)
srinath-ctds
pushed a commit
to datastax/pulsar
that referenced
this pull request
Dec 9, 2024
…n consumer creation (apache#23254) (cherry picked from commit 7fc88d6) (cherry picked from commit 5dec2e2)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
cherry-picked/branch-3.0
cherry-picked/branch-3.3
cherry-picked/branch-4.0
doc-not-needed
Your PR changes do not impact docs
release/3.0.8
release/3.3.3
release/4.0.1
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
When
allowAutoSubscriptionCreation
is set tofalse
on broker, creating a consumer for a subscription that does not exist does not throw aSubscriptionNotFoundException
. Instead, it throws aPulsarClientException
. This behavior complicates determining whether the subscription exists, requiring users to perform checks likegetRootCause(e).getMessage().matches(".*Subscription .*does not exist.*")
before #22164. Even after #22164, while the root cause becomesSubscriptionNotFoundException
, additional handling is still necessary.Modifications
This change modifies the code to throw
SubscriptionNotFoundException
directly when attempting to create a consumer for a non-existent subscription. This exception is a subclass ofPulsarClientException
, ensuring backward compatibility and providing a clearer error handling path for users.Verifying this change
This PR also updates the corresponding test in
org.apache.pulsar.client.api.MultiTopicsConsumerTest#testSubscriptionNotFound
.Does this pull request potentially affect one of the following parts:
If the box was checked, please highlight the changes
Documentation
doc
doc-required
doc-not-needed
doc-complete
Matching PR in forked repository
PR in forked repository: Shawyeok#17