Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[fix] Bump io.grpc from 1.56.0 to 1.56.1 #23276

Merged
merged 2 commits into from
Sep 10, 2024

Conversation

mattisonchao
Copy link
Member

@mattisonchao mattisonchao commented Sep 10, 2024

Motivation

Bump io.grpc from 1.56.0 to 1.56.1 to address this important fix. grpc/grpc-java#10328

Modifications

  • Bump io.grpc from 1.56.0 to 1.56.1

Verifying this change

  • Make sure that the change passes the CI checks.

Documentation

  • doc-not-needed

@mattisonchao mattisonchao self-assigned this Sep 10, 2024
@github-actions github-actions bot added the doc-not-needed Your PR changes do not impact docs label Sep 10, 2024
@mattisonchao mattisonchao reopened this Sep 10, 2024
@mattisonchao mattisonchao changed the title Bump io.grpc from 1.56.0 to 1.56.1 [fix] Bump io.grpc from 1.56.0 to 1.56.1 Sep 10, 2024
@codecov-commenter
Copy link

codecov-commenter commented Sep 10, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 74.54%. Comparing base (bbc6224) to head (f4a498f).
Report is 571 commits behind head on master.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff              @@
##             master   #23276      +/-   ##
============================================
+ Coverage     73.57%   74.54%   +0.97%     
- Complexity    32624    34288    +1664     
============================================
  Files          1877     1926      +49     
  Lines        139502   145037    +5535     
  Branches      15299    15856     +557     
============================================
+ Hits         102638   108123    +5485     
+ Misses        28908    28646     -262     
- Partials       7956     8268     +312     
Flag Coverage Δ
inttests 27.95% <ø> (+3.37%) ⬆️
systests 24.66% <ø> (+0.33%) ⬆️
unittests 73.89% <ø> (+1.05%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

see 562 files with indirect coverage changes

Copy link
Member

@lhotari lhotari left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lhotari
Copy link
Member

lhotari commented Sep 10, 2024

Bump io.grpc from 1.56.0 to 1.56.1 to address this super important fix. grpc/grpc-java#10328

@mattisonchao Please share the context to others about why this is important for Pulsar.

@mattisonchao
Copy link
Member Author

mattisonchao commented Sep 10, 2024

Please share the context to others about why this is important for Pulsar.

Pulsar is pluggable messaging system. For some plugins such as oxia metadata that is using GRPC as the RPC framework will affected by this bug. (grpc/grpc-java#10328) the bug will cause the client can't do reconnecting after hit UnknownHostException.

@mattisonchao mattisonchao merged commit 96fd04b into apache:master Sep 10, 2024
72 of 78 checks passed
@mattisonchao mattisonchao deleted the grpc.upgrade branch September 10, 2024 05:57
mattisonchao added a commit that referenced this pull request Sep 10, 2024
michalcukierman pushed a commit to michalcukierman/pulsar that referenced this pull request Sep 11, 2024
@lhotari lhotari added this to the 4.0.0 milestone Oct 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
doc-not-needed Your PR changes do not impact docs ready-to-test
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants