-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[fix][broker] fix the log format error in the AdminResource #23278
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
## Motivation The log message in `AdminResource` was missing a parameter. The `topicName` was not being included in the success log message when creating partitioned topics for remote clusters. This results the following errors: ``` ERROR Unable to format msg: [{}] Successfully created partitioned for topic {} for the remote clusters java.lang.IllegalArgumentException: found 2 argument placeholders, but provided 1 for pattern `[{}] Successfully created partitioned for topic {} for the remote clusters` ``` ## Modifications Corrected the log message by adding the missing `topicName` parameter to the success log entry in the `internalCreatePartitionedTopicToReplicatedClustersInBackground` method.
RobertIndie
added
type/bug
The PR fixed a bug or issue reported a bug
area/broker
labels
Sep 10, 2024
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #23278 +/- ##
============================================
+ Coverage 73.57% 74.50% +0.93%
- Complexity 32624 33771 +1147
============================================
Files 1877 1926 +49
Lines 139502 145037 +5535
Branches 15299 15856 +557
============================================
+ Hits 102638 108065 +5427
+ Misses 28908 28697 -211
- Partials 7956 8275 +319
Flags with carried forward coverage won't be shown. Click here to find out more.
|
Technoboy-
approved these changes
Sep 11, 2024
lhotari
pushed a commit
that referenced
this pull request
Sep 11, 2024
(cherry picked from commit d4839fb)
michalcukierman
pushed a commit
to michalcukierman/pulsar
that referenced
this pull request
Sep 11, 2024
nikhil-ctds
pushed a commit
to datastax/pulsar
that referenced
this pull request
Sep 12, 2024
srinath-ctds
pushed a commit
to datastax/pulsar
that referenced
this pull request
Sep 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
area/broker
cherry-picked/branch-3.0
doc-not-needed
Your PR changes do not impact docs
ready-to-test
release/3.0.8
type/bug
The PR fixed a bug or issue reported a bug
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
The log message in
AdminResource
was missing a parameter. ThetopicName
was not being included in the success log message when creating partitioned topics for remote clusters.This results the following errors:
This issue was introduced by #23169, so we also need to cherry-pick this PR to the branch-3.0
Modifications
Corrected the log message by adding the missing
topicName
parameter to the success log entry in theinternalCreatePartitionedTopicToReplicatedClustersInBackground
method.Verifying this change
(Please pick either of the following options)
This change is a trivial rework / code cleanup without any test coverage.
(or)
This change is already covered by existing tests, such as (please describe tests).
(or)
This change added tests and can be verified as follows:
(example:)
Does this pull request potentially affect one of the following parts:
If the box was checked, please highlight the changes
Documentation
doc
doc-required
doc-not-needed
doc-complete
Matching PR in forked repository
PR in forked repository: