Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[fix][broker] fix the log format error in the AdminResource #23278

Merged
merged 1 commit into from
Sep 11, 2024

Conversation

RobertIndie
Copy link
Member

@RobertIndie RobertIndie commented Sep 10, 2024

Motivation

The log message in AdminResource was missing a parameter. The topicName was not being included in the success log message when creating partitioned topics for remote clusters.

This results the following errors:

ERROR Unable to format msg: [{}] Successfully created partitioned for topic {} for the remote clusters java.lang.IllegalArgumentException: found 2 argument placeholders, but provided 1 for pattern `[{}] Successfully created partitioned for topic {} for the remote clusters`

This issue was introduced by #23169, so we also need to cherry-pick this PR to the branch-3.0

Modifications

Corrected the log message by adding the missing topicName parameter to the success log entry in the internalCreatePartitionedTopicToReplicatedClustersInBackground method.

Verifying this change

  • Make sure that the change passes the CI checks.

(Please pick either of the following options)

This change is a trivial rework / code cleanup without any test coverage.

(or)

This change is already covered by existing tests, such as (please describe tests).

(or)

This change added tests and can be verified as follows:

(example:)

  • Added integration tests for end-to-end deployment with large payloads (10MB)
  • Extended integration test for recovery after broker failure

Does this pull request potentially affect one of the following parts:

If the box was checked, please highlight the changes

  • Dependencies (add or upgrade a dependency)
  • The public API
  • The schema
  • The default values of configurations
  • The threading model
  • The binary protocol
  • The REST endpoints
  • The admin CLI options
  • The metrics
  • Anything that affects deployment

Documentation

  • doc
  • doc-required
  • doc-not-needed
  • doc-complete

Matching PR in forked repository

PR in forked repository:

## Motivation
The log message in `AdminResource` was missing a parameter. The `topicName` was not being included in the success log message when creating partitioned topics for remote clusters.

This results the following errors:
```
ERROR Unable to format msg: [{}] Successfully created partitioned for topic {} for the remote clusters java.lang.IllegalArgumentException: found 2 argument placeholders, but provided 1 for pattern `[{}] Successfully created partitioned for topic {} for the remote clusters`
```

## Modifications
Corrected the log message by adding the missing `topicName` parameter to the success log entry in the `internalCreatePartitionedTopicToReplicatedClustersInBackground` method.
@RobertIndie RobertIndie self-assigned this Sep 10, 2024
@RobertIndie RobertIndie added this to the 4.0.0 milestone Sep 10, 2024
@RobertIndie RobertIndie added type/bug The PR fixed a bug or issue reported a bug area/broker labels Sep 10, 2024
@github-actions github-actions bot added the doc-not-needed Your PR changes do not impact docs label Sep 10, 2024
@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 74.50%. Comparing base (bbc6224) to head (adec340).
Report is 572 commits behind head on master.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff              @@
##             master   #23278      +/-   ##
============================================
+ Coverage     73.57%   74.50%   +0.93%     
- Complexity    32624    33771    +1147     
============================================
  Files          1877     1926      +49     
  Lines        139502   145037    +5535     
  Branches      15299    15856     +557     
============================================
+ Hits         102638   108065    +5427     
+ Misses        28908    28697     -211     
- Partials       7956     8275     +319     
Flag Coverage Δ
inttests 27.93% <100.00%> (+3.34%) ⬆️
systests 24.64% <100.00%> (+0.32%) ⬆️
unittests 73.87% <100.00%> (+1.02%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
.../org/apache/pulsar/broker/admin/AdminResource.java 76.26% <100.00%> (-1.37%) ⬇️

... and 552 files with indirect coverage changes

@Technoboy- Technoboy- merged commit d4839fb into apache:master Sep 11, 2024
60 of 63 checks passed
lhotari pushed a commit that referenced this pull request Sep 11, 2024
michalcukierman pushed a commit to michalcukierman/pulsar that referenced this pull request Sep 11, 2024
nikhil-ctds pushed a commit to datastax/pulsar that referenced this pull request Sep 12, 2024
srinath-ctds pushed a commit to datastax/pulsar that referenced this pull request Sep 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/broker cherry-picked/branch-3.0 doc-not-needed Your PR changes do not impact docs ready-to-test release/3.0.8 type/bug The PR fixed a bug or issue reported a bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants