Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[feat][client] PIP-374: Visibility of messages in receiverQueue for the consumers #23303

Merged
merged 2 commits into from
Sep 17, 2024
Merged

[feat][client] PIP-374: Visibility of messages in receiverQueue for the consumers #23303

merged 2 commits into from
Sep 17, 2024

Conversation

shibd
Copy link
Member

@shibd shibd commented Sep 13, 2024

Motivation

#23235

Modifications

  • Add onArrival method to ConsumerInterceptor.
  • Call onArrival method when message received and successful deserialize.

Verifying this change

  • Add testConsumerInterceptorForOnArrive to cover it.

Does this pull request potentially affect one of the following parts:

If the box was checked, please highlight the changes

  • Dependencies (add or upgrade a dependency)
  • The public API
  • The schema
  • The default values of configurations
  • The threading model
  • The binary protocol
  • The REST endpoints
  • The admin CLI options
  • The metrics
  • Anything that affects deployment

Documentation

  • doc
  • doc-required
  • doc-not-needed
  • doc-complete

@shibd shibd added the type/feature The PR added a new feature or issue requested a new feature label Sep 13, 2024
@shibd shibd added this to the 4.0.0 milestone Sep 13, 2024
@shibd shibd self-assigned this Sep 13, 2024
@github-actions github-actions bot added the PIP label Sep 13, 2024
@shibd shibd closed this Sep 13, 2024
@shibd shibd reopened this Sep 13, 2024
@github-actions github-actions bot added the doc-required Your PR changes impact docs and you will update later. label Sep 13, 2024
@shibd shibd merged commit 2e98736 into apache:master Sep 17, 2024
71 of 78 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@coderzc coderzc coderzc approved these changes

@Technoboy- Technoboy- Awaiting requested review from Technoboy-

@codelipenghui codelipenghui Awaiting requested review from codelipenghui

@liangyepianzhou liangyepianzhou Awaiting requested review from liangyepianzhou

Assignees

@shibd shibd

Labels
doc-required Your PR changes impact docs and you will update later. PIP ready-to-test type/feature The PR added a new feature or issue requested a new feature
Projects
None yet
Milestone
4.0.0
Development

Successfully merging this pull request may close these issues.
2 participants
@shibd @coderzc