Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[improve][pip] PIP-381: Handle large PositionInfo state #23328

Merged
merged 5 commits into from
Oct 1, 2024
Merged

[improve][pip] PIP-381: Handle large PositionInfo state #23328

merged 5 commits into from
Oct 1, 2024

Conversation

dlg99
Copy link
Contributor

@dlg99 dlg99 commented Sep 20, 2024

Documentation

  • doc
  • doc-required
  • doc-not-needed
  • doc-complete

Proposed implementation: #22799

@github-actions github-actions bot added PIP doc-not-needed Your PR changes do not impact docs labels Sep 20, 2024
@dlg99 dlg99 force-pushed the pip/large-position-info branch from 4298c15 to 124255a Compare September 20, 2024 23:36
lhotari
lhotari reviewed Sep 27, 2024
View reviewed changes
Copy link
Member

@lhotari lhotari left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add the details about the feature flag persistentUnackedRangesWithMultipleEntriesEnabled to this PIP document and the proposed default value. It would also be useful to mention that this PIP takes over PIP-81 which was never implemented.

lhotari
lhotari approved these changes Oct 1, 2024
View reviewed changes
Copy link
Member

@lhotari lhotari left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dlg99 dlg99 merged commit 50802be into apache:master Oct 1, 2024
20 checks passed
@lhotari lhotari added this to the 4.0.0 milestone Oct 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lhotari lhotari lhotari approved these changes

Assignees
No one assigned
Labels
doc-not-needed Your PR changes do not impact docs PIP
Projects
None yet
Milestone
4.0.0
Development

Successfully merging this pull request may close these issues.
2 participants
@dlg99 @lhotari