[fix][build] Remove io.grpc.netty relocation

[nodece]

Motivation

I'm trying to release the private pulsar 3.0.x, and encountered a compilation issue:

$ mvn -T 1C -B -ntp install deploy -Pxxxx-release -DskipTests -Dlicense.skip=true -Dspotbugs.skip=true -Drat.skip=true -Dcheckstyle.skip=true

....
Error:  Failed to execute goal org.apache.maven.plugins:maven-compiler-plugin:3.11.0:compile (default-compile) on project pulsar-metadata: Compilation failure
Error:  /pulsar/pulsar-metadata/src/main/java/org/apache/pulsar/metadata/impl/EtcdMetadataStore.java:[147,34] cannot access io.grpc.netty.shaded.io.grpc.netty.shaded.io.netty.handler.ssl.SslContext
Error:    class file for io.grpc.netty.shaded.io.grpc.netty.shaded.io.netty.handler.ssl.SslContext not found
Error:  -> [Help 1]
Error:  

#22892 introduces grpc-netty-shaded, the maven-shade-plugin rewrites io.grpc.netty.shaded.io.netty.handler.ssl.SslContext to io.grpc.netty.shaded.io.grpc.netty.shaded.io.netty.handler.ssl.SslContext, which have broken the compilation.

The import of the io.grpc.netty.shaded.* should be excluded.

Modifications

• Exclude io.grpc.netty.shaded.* in the io.grpc.netty relocation.

Documentation

• doc
• doc-required
• doc-not-needed
• doc-complete

[nodece]

/pulsarbot rerun-failure-checks

[lhotari]

This would require upgrading grpc to a version that is compatible with Netty 4.1.111.Final, please check #22892 for some details.

[nodece]

/pulsarbot rerun-failure-checks

[nodece]

Converted to draft, some tests have failed.

[nodece]

/pulsarbot rerun-failure-checks

[codecov-commenter]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 74.54%. Comparing base (bbc6224) to head (14b1027).
Report is 599 commits behind head on master.

Additional details and impacted files

@@             Coverage Diff              @@
##             master   #23342      +/-   ##
============================================
+ Coverage     73.57%   74.54%   +0.96%     
- Complexity    32624    34430    +1806     
============================================
  Files          1877     1934      +57     
  Lines        139502   144981    +5479     
  Branches      15299    15839     +540     
============================================
+ Hits         102638   108069    +5431     
+ Misses        28908    28635     -273     
- Partials       7956     8277     +321     

Flag	Coverage Δ
inttests	27.58% <ø> (+3.00%)	⬆️
systests	24.59% <ø> (+0.26%)	⬆️
unittests	73.88% <ø> (+1.03%)	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

see 600 files with indirect coverage changes

[nodece]

The mvn deploy includes package phase, this causes the jetcd to relocate multiple times.

[lhotari]

The mvn deploy includes package phase, this causes the jetcd to relocate multiple times.

@nodece is there a way to address that? It might get triggered in our releases too.

[nodece]

I checked the Pulsar release document, it is correct.

“mvn deploy” is correct, “mvn install deploy” is incorrect.