Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[improve] Install openssl in the docker image to fix compatibility with Apache Pulsar Helm chart #23362

Merged
merged 1 commit into from
Sep 29, 2024

Conversation

lhotari
Copy link
Member

@lhotari lhotari commented Sep 27, 2024

Motivation

Apache Pulsar Helm chart requires openssl in the docker image.

Modifications

Install the openssl package.

Documentation

  • doc
  • doc-required
  • doc-not-needed
  • doc-complete

@lhotari lhotari added release/blocker Indicate the PR or issue that should block the release until it gets resolved ready-to-test release/3.3.2 labels Sep 27, 2024
@lhotari lhotari added this to the 4.0.0 milestone Sep 27, 2024
@lhotari lhotari requested a review from merlimat September 27, 2024 16:16
@lhotari lhotari self-assigned this Sep 27, 2024
@github-actions github-actions bot added the doc-not-needed Your PR changes do not impact docs label Sep 27, 2024
@lhotari
Copy link
Member Author

lhotari commented Sep 27, 2024

Testing again in apache/pulsar-helm-chart#530 .
I patched the 4.0.0-preview.1 image with this type of Dockerfile:

ARG IMAGE=apachepulsar/pulsar-all
ARG TAG=4.0.0-preview.1
FROM ${IMAGE}:${TAG}
USER 0
RUN apk add openssl
USER 10000

@lhotari
Copy link
Member Author

lhotari commented Sep 27, 2024

@lhotari
Copy link
Member Author

lhotari commented Sep 27, 2024

There seem to be additional problem, https://github.com/apache/pulsar-helm-chart/actions/runs/11074466958/job/30773380309?pr=530

This is a problem in the Helm chart:

[pod/pulsar-ci-zookeeper-0/pulsar-ci-zookeeper] pkcs12: Can't open "/pulsar/zookeeper.p12" for writing, Permission denied
[pod/pulsar-ci-zookeeper-0/pulsar-ci-zookeeper] Importing keystore /pulsar/zookeeper.p12 to /pulsar/zookeeper.keystore.jks...

It's trying to write files to /pulsar directory. I'll address that in the Helm chart.

@lhotari
Copy link
Member Author

lhotari commented Sep 27, 2024

I patched the 4.0.0-preview.1 docker images and included openssl so that users won't run into the issues related to missing openssl while testing the images. I performed patching using the solution described in #23362 (comment) .

@lhotari
Copy link
Member Author

lhotari commented Sep 27, 2024

Apache Pulsar Helm chart fix in progress in apache/pulsar-helm-chart#531

@lhotari lhotari closed this Sep 29, 2024
@lhotari lhotari reopened this Sep 29, 2024
@codecov-commenter
Copy link

codecov-commenter commented Sep 29, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 73.73%. Comparing base (bbc6224) to head (bc983b2).
Report is 611 commits behind head on master.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff              @@
##             master   #23362      +/-   ##
============================================
+ Coverage     73.57%   73.73%   +0.16%     
+ Complexity    32624     2738   -29886     
============================================
  Files          1877     1934      +57     
  Lines        139502   145363    +5861     
  Branches      15299    15945     +646     
============================================
+ Hits         102638   107189    +4551     
- Misses        28908    29848     +940     
- Partials       7956     8326     +370     
Flag Coverage Δ
inttests 27.87% <ø> (+3.28%) ⬆️
systests 24.51% <ø> (+0.19%) ⬆️
unittests 73.10% <ø> (+0.25%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

see 618 files with indirect coverage changes

@lhotari lhotari merged commit 7e59bde into apache:master Sep 29, 2024
100 of 105 checks passed
lhotari added a commit that referenced this pull request Oct 4, 2024
…th Apache Pulsar Helm chart (#23362)

(cherry picked from commit 7e59bde)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cherry-picked/branch-3.3 doc-not-needed Your PR changes do not impact docs ready-to-test release/blocker Indicate the PR or issue that should block the release until it gets resolved release/3.3.2
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants