Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[improve][broker] Add log to track issue when handleGetTopicsOfNamespace #23434

Merged
merged 1 commit into from
Oct 14, 2024

Conversation

Technoboy-
Copy link
Contributor

Motivation

image

Documentation

  • doc
  • doc-required
  • doc-not-needed
  • doc-complete

@Technoboy- Technoboy- self-assigned this Oct 10, 2024
@github-actions github-actions bot added the doc-not-needed Your PR changes do not impact docs label Oct 10, 2024
@Technoboy- Technoboy- added ready-to-test and removed doc-not-needed Your PR changes do not impact docs labels Oct 10, 2024
@Technoboy- Technoboy- added this to the 4.0.0 milestone Oct 10, 2024
@Technoboy- Technoboy- closed this Oct 10, 2024
@Technoboy- Technoboy- reopened this Oct 10, 2024
@github-actions github-actions bot added the doc-not-needed Your PR changes do not impact docs label Oct 10, 2024
@codecov-commenter
Copy link

codecov-commenter commented Oct 11, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 74.34%. Comparing base (bbc6224) to head (a44e14c).
Report is 669 commits behind head on master.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff              @@
##             master   #23434      +/-   ##
============================================
+ Coverage     73.57%   74.34%   +0.76%     
- Complexity    32624    34456    +1832     
============================================
  Files          1877     1953      +76     
  Lines        139502   147177    +7675     
  Branches      15299    16204     +905     
============================================
+ Hits         102638   109414    +6776     
- Misses        28908    29328     +420     
- Partials       7956     8435     +479     
Flag Coverage Δ
inttests 27.71% <0.00%> (+3.13%) ⬆️
systests 24.37% <100.00%> (+0.04%) ⬆️
unittests 73.69% <100.00%> (+0.85%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
...va/org/apache/pulsar/broker/service/ServerCnx.java 72.53% <100.00%> (+0.39%) ⬆️

... and 636 files with indirect coverage changes

@lhotari lhotari modified the milestones: 4.0.0, 4.1.0 Oct 11, 2024
Copy link
Member

@lhotari lhotari left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lhotari lhotari modified the milestones: 4.1.0, 4.0.0 Oct 14, 2024
@lhotari lhotari merged commit 33475ec into apache:master Oct 14, 2024
53 of 55 checks passed
lhotari pushed a commit that referenced this pull request Oct 14, 2024
lhotari pushed a commit that referenced this pull request Oct 14, 2024
nikhil-ctds pushed a commit to datastax/pulsar that referenced this pull request Oct 15, 2024
…pace` (apache#23434)

(cherry picked from commit 33475ec)
(cherry picked from commit 26f4a40)
srinath-ctds pushed a commit to datastax/pulsar that referenced this pull request Oct 16, 2024
…pace` (apache#23434)

(cherry picked from commit 33475ec)
(cherry picked from commit 26f4a40)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants