-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[fix][build] Add basic support for vscode-java and Eclipse IDE #23448
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lhotari
requested review from
merlimat,
Technoboy-,
eolivelli,
nodece,
nicoloboschi and
michaeljmarshall
October 12, 2024 18:53
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #23448 +/- ##
============================================
+ Coverage 73.57% 74.37% +0.79%
- Complexity 32624 34401 +1777
============================================
Files 1877 1943 +66
Lines 139502 146919 +7417
Branches 15299 16179 +880
============================================
+ Hits 102638 109267 +6629
- Misses 28908 29231 +323
- Partials 7956 8421 +465
Flags with carried forward coverage won't be shown. Click here to find out more. |
lhotari
force-pushed
the
lh-vscode-java-support
branch
from
October 14, 2024 04:45
52ce15e
to
a5a4e2c
Compare
lhotari
force-pushed
the
lh-vscode-java-support
branch
from
October 14, 2024 05:03
a5a4e2c
to
e27fb4d
Compare
lhotari
changed the title
[fix][build] Add basic support for vscode-java
[fix][build] Add basic support for vscode-java and Eclipse IDE
Oct 14, 2024
Technoboy-
approved these changes
Oct 14, 2024
lhotari
added a commit
that referenced
this pull request
Oct 14, 2024
(cherry picked from commit 209fd78)
lhotari
added a commit
that referenced
this pull request
Oct 14, 2024
(cherry picked from commit 209fd78)
nikhil-ctds
pushed a commit
to datastax/pulsar
that referenced
this pull request
Oct 15, 2024
srinath-ctds
pushed a commit
to datastax/pulsar
that referenced
this pull request
Oct 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
area/build
cherry-picked/branch-3.0
cherry-picked/branch-3.3
doc-not-needed
Your PR changes do not impact docs
ready-to-test
release/3.0.8
release/3.3.3
release/4.0.0
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Visual Studio Code (vscode) is a popular IDE. It would be great to support developing Pulsar with vscode-java.
One of the reasons for adding vscode-java support is due to Cursor AI code editor building upon vscode. When there's vscode-java support in Pulsar, it would be possible to use Cursor for developing Pulsar.
Similar changes are most likely required for supporting Eclipse for Apache Pulsar development since vscode-java uses Eclipse modules under the covers for Java and Maven support.
The lightproto maven plugin issue most likely impacts IntelliJ too since currently you need to build Pulsar once in order to get lightproto generated classes to resolve. This change will most likely address that issue too.
Modifications
Example test run
Additional context
UPDATE: Please see Setting up an IDE to setup VS Code for Pulsar development.
I got test running working with this
settings.json
for "Language Support for Java(TM) by Red Hat" extensionsdkman setup for JDK versions is explained currently in https://pulsar.apache.org/contribute/release-process/#preparation
in workspace level
settings.json
configured in
Also setting
-Pcore-modules,-main
to speed up compilationAlso setting profiles in the root project:
Since
"java.autobuild.enabled": false
, you will need to build manually. Having autobuilding disabled is useful for a large project like Pulsar since building will consume resources and it conflicts with manual builds on the command line.Documentation
doc
doc-required
doc-not-needed
doc-complete