[fix][client] Fix the javadoc for ConsumerBuilder.isAckReceiptEnabled #23452
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lhotari
added
release/blocker
lhotari
requested review from
nodece,
BewareMyPower,
nicoloboschi and
poorbarcode
github-actions
bot
added
the
doc
eolivelli
approved these changes
Oct 14, 2024
pulsar-client-api/src/main/java/org/apache/pulsar/client/api/ConsumerBuilder.java
Show resolved
Hide resolved
Technoboy-
approved these changes
Oct 14, 2024
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #23452 +/- ##
============================================
+ Coverage 73.57% 74.34% +0.77%
- Complexity 32624 34401 +1777
============================================
Files 1877 1943 +66
Lines 139502 146947 +7445
Branches 15299 16187 +888
============================================
+ Hits 102638 109255 +6617
- Misses 28908 29261 +353
- Partials 7956 8431 +475
Flags with carried forward coverage won't be shown. Click here to find out more. |
nodece
approved these changes
Oct 14, 2024
nikhil-ctds
pushed a commit
to datastax/pulsar
that referenced
this pull request
Oct 15, 2024
…apache#23452) (cherry picked from commit e2fb0da) (cherry picked from commit de9c065)
srinath-ctds
pushed a commit
to datastax/pulsar
that referenced
this pull request
Oct 16, 2024
…apache#23452) (cherry picked from commit e2fb0da) (cherry picked from commit de9c065)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #23249
Motivation
The current javadoc for ConsumerBuilder.isAckReceiptEnabled doesn't make sense and it's wrong, see #23249 for details.
Modifications
Fix the javadoc.
Documentation
docdoc-requireddoc-not-neededdoc-complete