[fix][client] Prevent embedding protobuf-java class files in pulsar-client-admin and pulsar-client-all #23468
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 tasks
lhotari
requested changes
Oct 16, 2024
Shawyeok
changed the title
lhotari
changed the title
lhotari
changed the title
lhotari
changed the title
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #23468 +/- ##
============================================
- Coverage 73.57% 73.47% -0.11%
+ Complexity 32624 2642 -29982
============================================
Files 1877 1943 +66
Lines 139502 146973 +7471
Branches 15299 16191 +892
============================================
+ Hits 102638 107985 +5347
- Misses 28908 30539 +1631
- Partials 7956 8449 +493
Flags with carried forward coverage won't be shown. Click here to find out more. |
nikhil-ctds
pushed a commit
to datastax/pulsar
that referenced
this pull request
Oct 28, 2024
…lient-admin and pulsar-client-all (apache#23468) (cherry picked from commit 63c6a25) (cherry picked from commit 521b7b4)
nikhil-ctds
pushed a commit
to datastax/pulsar
that referenced
this pull request
Nov 6, 2024
…lient-admin and pulsar-client-all (apache#23468) (cherry picked from commit 63c6a25) (cherry picked from commit 521b7b4)
nikhil-ctds
pushed a commit
to datastax/pulsar
that referenced
this pull request
Nov 6, 2024
…lient-admin and pulsar-client-all (apache#23468) (cherry picked from commit 63c6a25) (cherry picked from commit 521b7b4)
srinath-ctds
pushed a commit
to datastax/pulsar
that referenced
this pull request
Nov 6, 2024
…lient-admin and pulsar-client-all (apache#23468) (cherry picked from commit 63c6a25) (cherry picked from commit 521b7b4)
This was referenced Nov 22, 2024
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #22263
Motivation
Since version 3.0.0,
com.google.protobuf:protobuf-javahas been directly included inpulsar-client-adminorpulsar-client-allwithout relocation (i.e., the classes remain in their original package). This is considered bad practice as it may cause conflicts with the user’s application’s version ofprotobuf-java. For example, I encountered this issue in a program that consumes Pulsar messages and writes to a Parquet file using the protobuf schema.By not shading
protobuf-java, users can select their desired version ofprotobuf-java.More details explained in #22263 (comment)
Modifications
Prevent shade
protobuf-java, move it into transitive dependencies, keep consistency withpulsar-client.Verifying this change
Does this pull request potentially affect one of the following parts:
If the box was checked, please highlight the changes
Documentation
docdoc-requireddoc-not-neededdoc-completeMatching PR in forked repository
PR in forked repository: Shawyeok#14