Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[improve][test] Added message properties tests for batch and non-batch messages #23473

Merged
merged 2 commits into from
Oct 18, 2024

Conversation

codelipenghui
Copy link
Contributor

Motivation

Added message properties tests for batch and non-batch messages.

Does this pull request potentially affect one of the following parts:

If the box was checked, please highlight the changes

  • Dependencies (add or upgrade a dependency)
  • The public API
  • The schema
  • The default values of configurations
  • The threading model
  • The binary protocol
  • The REST endpoints
  • The admin CLI options
  • The metrics
  • Anything that affects deployment

Documentation

  • doc
  • doc-required
  • doc-not-needed
  • doc-complete

@codelipenghui codelipenghui self-assigned this Oct 17, 2024
@github-actions github-actions bot added the doc-not-needed Your PR changes do not impact docs label Oct 17, 2024
@codecov-commenter
Copy link

codecov-commenter commented Oct 17, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 74.31%. Comparing base (bbc6224) to head (b06f456).
Report is 686 commits behind head on master.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff              @@
##             master   #23473      +/-   ##
============================================
+ Coverage     73.57%   74.31%   +0.73%     
- Complexity    32624    34389    +1765     
============================================
  Files          1877     1943      +66     
  Lines        139502   146973    +7471     
  Branches      15299    16191     +892     
============================================
+ Hits         102638   109221    +6583     
- Misses        28908    29329     +421     
- Partials       7956     8423     +467     
Flag Coverage Δ
inttests 27.28% <ø> (+2.70%) ⬆️
systests 24.37% <ø> (+0.05%) ⬆️
unittests 73.68% <ø> (+0.83%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

see 649 files with indirect coverage changes

@codelipenghui codelipenghui added this to the 4.1.0 milestone Oct 18, 2024
Copy link
Member

@lhotari lhotari left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for contributing @codelipenghui

@lhotari lhotari merged commit 8de27a2 into apache:master Oct 18, 2024
57 checks passed
lhotari pushed a commit that referenced this pull request Oct 21, 2024
lhotari pushed a commit that referenced this pull request Oct 21, 2024
nikhil-ctds pushed a commit to datastax/pulsar that referenced this pull request Oct 28, 2024
…h messages (apache#23473)

(cherry picked from commit 8de27a2)
(cherry picked from commit 986a4db)
nikhil-ctds pushed a commit to datastax/pulsar that referenced this pull request Nov 6, 2024
…h messages (apache#23473)

(cherry picked from commit 8de27a2)
(cherry picked from commit 986a4db)
srinath-ctds pushed a commit to datastax/pulsar that referenced this pull request Nov 7, 2024
…h messages (apache#23473)

(cherry picked from commit 8de27a2)
(cherry picked from commit 986a4db)
hanmz pushed a commit to hanmz/pulsar that referenced this pull request Feb 12, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants