Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[fix][ci] Temporarily move OneWayReplicatorTestBase tests to flaky group to unblock CI #23478

Merged
merged 1 commit into from
Oct 17, 2024

Conversation

lhotari
Copy link
Member

@lhotari lhotari commented Oct 17, 2024

Motivation

Pulsar CI is blocked by #23474.
Mailing list discussion: https://lists.apache.org/thread/7m075w1qthzo01rzfz7fb236ok00hdo7

Modifications

Move all OneWayReplicatorTestBase tests to flaky group until the problem is resolved.

Documentation

  • doc
  • doc-required
  • doc-not-needed
  • doc-complete

@lhotari lhotari added this to the 4.1.0 milestone Oct 17, 2024
@lhotari lhotari self-assigned this Oct 17, 2024
@github-actions github-actions bot added the doc-not-needed Your PR changes do not impact docs label Oct 17, 2024
Copy link
Member

@dao-jun dao-jun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@codecov-commenter
Copy link

codecov-commenter commented Oct 17, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 74.29%. Comparing base (bbc6224) to head (251ed41).
Report is 686 commits behind head on master.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff              @@
##             master   #23478      +/-   ##
============================================
+ Coverage     73.57%   74.29%   +0.72%     
- Complexity    32624    34386    +1762     
============================================
  Files          1877     1943      +66     
  Lines        139502   146973    +7471     
  Branches      15299    16191     +892     
============================================
+ Hits         102638   109200    +6562     
- Misses        28908    29339     +431     
- Partials       7956     8434     +478     
Flag Coverage Δ
inttests 27.71% <ø> (+3.13%) ⬆️
systests 24.42% <ø> (+0.09%) ⬆️
unittests 73.66% <ø> (+0.82%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

see 650 files with indirect coverage changes

@lhotari lhotari merged commit 6933a1d into apache:master Oct 17, 2024
54 of 55 checks passed
poorbarcode added a commit to poorbarcode/pulsar that referenced this pull request Oct 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
doc-not-needed Your PR changes do not impact docs ready-to-test
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants