Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[feat][monitor] Add offloader stats grafana dashboard #23479

Merged
merged 1 commit into from
Oct 18, 2024

Conversation

dao-jun
Copy link
Member

@dao-jun dao-jun commented Oct 17, 2024

Motivation

Add grafana dashboard of offloader stats which introduced by #13833

image

Modifications

Verifying this change

  • Make sure that the change passes the CI checks.

(Please pick either of the following options)

This change is a trivial rework / code cleanup without any test coverage.

(or)

This change is already covered by existing tests, such as (please describe tests).

(or)

This change added tests and can be verified as follows:

(example:)

  • Added integration tests for end-to-end deployment with large payloads (10MB)
  • Extended integration test for recovery after broker failure

Does this pull request potentially affect one of the following parts:

If the box was checked, please highlight the changes

  • Dependencies (add or upgrade a dependency)
  • The public API
  • The schema
  • The default values of configurations
  • The threading model
  • The binary protocol
  • The REST endpoints
  • The admin CLI options
  • The metrics
  • Anything that affects deployment

Documentation

  • doc
  • doc-required
  • doc-not-needed
  • doc-complete

Matching PR in forked repository

PR in forked repository:

@dao-jun dao-jun requested a review from lhotari October 17, 2024 12:14
@dao-jun dao-jun self-assigned this Oct 17, 2024
@github-actions github-actions bot added the doc-not-needed Your PR changes do not impact docs label Oct 17, 2024
@dao-jun dao-jun added area/metrics ready-to-test and removed doc-not-needed Your PR changes do not impact docs labels Oct 17, 2024
@github-actions github-actions bot added the doc-not-needed Your PR changes do not impact docs label Oct 17, 2024
@dao-jun dao-jun closed this Oct 17, 2024
@dao-jun dao-jun reopened this Oct 17, 2024
@dao-jun dao-jun changed the title Add offloader stats grafana dashboard [feat]Add offloader stats grafana dashboard Oct 17, 2024
@lhotari
Copy link
Member

lhotari commented Oct 17, 2024

Closing and reopening to get Pulsar CI unblocking changes included.

@lhotari lhotari closed this Oct 17, 2024
@lhotari lhotari reopened this Oct 17, 2024
Copy link
Member

@lhotari lhotari left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lhotari lhotari added this to the 4.1.0 milestone Oct 17, 2024
@lhotari
Copy link
Member

lhotari commented Oct 17, 2024

Thanks for contributing, @dao-jun

@codecov-commenter
Copy link

codecov-commenter commented Oct 17, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 74.19%. Comparing base (bbc6224) to head (e48e2f2).
Report is 686 commits behind head on master.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff              @@
##             master   #23479      +/-   ##
============================================
+ Coverage     73.57%   74.19%   +0.62%     
- Complexity    32624    34331    +1707     
============================================
  Files          1877     1943      +66     
  Lines        139502   146973    +7471     
  Branches      15299    16191     +892     
============================================
+ Hits         102638   109053    +6415     
- Misses        28908    29494     +586     
- Partials       7956     8426     +470     
Flag Coverage Δ
inttests 27.62% <ø> (+3.04%) ⬆️
systests 24.43% <ø> (+0.10%) ⬆️
unittests 73.54% <ø> (+0.70%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

see 654 files with indirect coverage changes

@lhotari lhotari changed the title [feat]Add offloader stats grafana dashboard [feat][monitor] Add offloader stats grafana dashboard Oct 18, 2024
@lhotari lhotari merged commit 6ebca5e into apache:master Oct 18, 2024
125 of 135 checks passed
@dao-jun dao-jun deleted the dev/offloader_dashboard branch October 18, 2024 07:54
lhotari pushed a commit that referenced this pull request Oct 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants