[fix][test] Fix memory leak via OTel shutdown hooks in tests #23483
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lhotari
requested review from
merlimat,
asafm,
Technoboy-,
codelipenghui,
nodece,
BewareMyPower,
dao-jun,
nicoloboschi and
heesung-sn
eolivelli
approved these changes
Oct 18, 2024
merlimat
approved these changes
Oct 18, 2024
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #23483 +/- ##
============================================
+ Coverage 73.57% 74.35% +0.77%
- Complexity 32624 34405 +1781
============================================
Files 1877 1943 +66
Lines 139502 146973 +7471
Branches 15299 16191 +892
============================================
+ Hits 102638 109275 +6637
- Misses 28908 29273 +365
- Partials 7956 8425 +469
Flags with carried forward coverage won't be shown. Click here to find out more. |
lhotari
added a commit
that referenced
this pull request
Oct 21, 2024
(cherry picked from commit 2d88a4e)
lhotari
added a commit
that referenced
this pull request
Nov 13, 2024
(cherry picked from commit 2d88a4e)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
OTel AutoConfiguredOpenTelemetrySdkBuilder will register a shutdown hook by default. This will cause a memory leak since there will be a reference to all OpenTelemetrySdk instances until the test JVM completes running tests.
Modifications
Disable registering shutdown hook in tests.
Documentation
docdoc-requireddoc-not-neededdoc-complete